Fix the delayed sequencer missing messages in tests #2651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the delayed sequencer might check block X before the inbox reader has read delayed messages from block X, and therefore the delayed sequencer wouldn't see any new delayed messages. Then, it'd wait for block X+1 before checking for new delayed messages again. However, in test cases, there might not be blocks produced regularly and therefore there might not be a block X+1 at all because the test is stuck waiting on the delayed message to be sequenced. Therefore, this PR regularly rechecks the delayed messages to see if it missed anything, which is very cheap because all it needs to do is compare the database's delayed message count to the database's delayed messages sequenced count.