Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove arbutil's L1Interface and use *ethclient.Client instead #2641

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Remove arbutil's L1Interface and use *ethclient.Client instead #2641

wants to merge 5 commits into from

Conversation

ganeshvanahalli
Copy link
Contributor

@ganeshvanahalli ganeshvanahalli commented Sep 6, 2024 •
edited
Loading

This PR removes arbutil's L1Interface and uses *ethclient.Client in its place

Resolves NIT-2763

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Sep 6, 2024
@ganeshvanahalli ganeshvanahalli marked this pull request as ready for review September 9, 2024 08:08
@ganeshvanahalli ganeshvanahalli changed the title Remove L1 interface and use *ethclient.Client instead Remove arbutil's L1Interface and use *ethclient.Client instead Sep 9, 2024
gligneul
gligneul reviewed Sep 9, 2024
View reviewed changes
Copy link
Contributor

@gligneul gligneul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just minor comments/questions.

arbnode/dataposter/dataposter_test.go Outdated Show resolved Hide resolved
arbnode/dataposter/dataposter_test.go Show resolved Hide resolved
arbutil/correspondingl1blocknumber.go Show resolved Hide resolved
staker/rollup_watcher.go Show resolved Hide resolved
eljobe
eljobe approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@eljobe eljobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eljobe eljobe eljobe approved these changes

@gligneul gligneul gligneul approved these changes

@amsanghi amsanghi Awaiting requested review from amsanghi

Assignees
No one assigned
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ganeshvanahalli @eljobe @gligneul