Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fastcache pin #2457

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Update fastcache pin #2457

merged 2 commits into from
Jul 8, 2024

Conversation

Tristan-Wilson
Copy link
Member

Updating module as per discussion in #2455

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jul 8, 2024
Copy link
Member

@eljobe eljobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower
Copy link
Collaborator

LGTM, but is this required for #2455 ? Shouldn't that PR allow the current commit because it's an ancestor of fastcache master which merges it in?

@Tristan-Wilson
Copy link
Member Author

LGTM, but is this required for #2455 ? Shouldn't that PR allow the current commit because it's an ancestor of fastcache master which merges it in?

You are correct, it doesn't appear to be required.

$ for mod in `git submodule --quiet foreach 'echo $name'`; do (cd $mod; if git merge-base --is-ancestor HEAD origin/HEAD; then echo OK $mod; else echo DIVERGENT $mod; fi); done
OK arbitrator/langs/bf
DIVERGENT arbitrator/langs/c
DIVERGENT arbitrator/langs/rust
DIVERGENT arbitrator/tools/wasmer
OK arbitrator/wasm-libraries/soft-float/SoftFloat
OK arbitrator/wasm-testsuite/testsuite
OK brotli
DIVERGENT contracts
OK fastcache
OK go-ethereum
OK nitro-testnode

Not sure why it was showing up before.

@Tristan-Wilson Tristan-Wilson merged commit bb0d379 into master Jul 8, 2024
11 of 12 checks passed
@Tristan-Wilson Tristan-Wilson deleted the update-fastcache-pin branch July 8, 2024 16:35
@PlasmaPower
Copy link
Collaborator

Not sure why it was showing up before.

I hadn't merged in the corresponding fastcache PR yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants