-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add submodule pin check to CI #2455
Conversation
This checks that submodules are ancestors of origin/HEAD so that non-merged branches aren't accidentally checked in.
Updated the arbitrator/langs/bf pin as it was fairly clear what to do. For the following I need experts on these submodules to take a look |
Co-authored-by: Gabriel de Quadros Ligneul <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
I made a PR to update nitro pin and will merge it back into this PR once it's merged
We should change the default GH branch to |
6a17a2d
to
919b737
Compare
This checks that submodules are ancestors of origin/HEAD or a configurable expected branch so that non-merged branches aren't accidentally checked in.
Fixes NIT-2604
Initially this will likely FAIL because we have some submodules that are not under origin/HEAD.
Testing done
This screenshot shows an example of what you see when it fails: