Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a notion of zombies to preserve empty account behavior #347

Merged
merged 5 commits into from
Nov 7, 2024

Conversation

PlasmaPower
Copy link
Collaborator

@PlasmaPower PlasmaPower commented Aug 5, 2024

Points into #346

Geth statedb changes in v1.14.2 mean that the old behavior of SubBalance amount 0 in respect to empty accounts has changed. This PR adds back in the old behavior using a notion of zombies.

Requires OffchainLabs/nitro#2732 for the new method to be used on the nitro side

@cla-bot cla-bot bot added the s CLA signed label Aug 5, 2024
Copy link
Contributor

@amsanghi amsanghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

@tsahee tsahee merged commit 219a778 into merge-v1.14.2 Nov 7, 2024
3 checks passed
@tsahee tsahee deleted the zombies-for-v1.14.2 branch November 7, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s CLA signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants