refactor: make getFastBridges reusable across components
#1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…ge into refactor-getFastBridges
brtkx
commented
Jul 27, 2023
| case FastBridgeNames.Connext: | ||
| return `https://bridge.connext.network/${tokenSymbol}-from-${slugFrom}-to-${slugTo}?amount=${amount}` | ||
| case FastBridgeNames.Across: | ||
| return 'https://across.to/bridge' |
There was a problem hiding this comment.
Across query params seem not to be working at all anymore.
brtkx
commented
Jul 27, 2023
| case FastBridgeNames.Stargate: | ||
| return `https://stargate.finance/transfer?srcChain=${slugFrom}&dstChain=${slugTo}&srcToken=${tokenSymbol}` | ||
| case FastBridgeNames.Synapse: | ||
| return 'https://synapseprotocol.com/' |
There was a problem hiding this comment.
Synapse doesn't use query params, but detects the currently connected network.
…e into refactor-getFastBridges
chrstph-dvx
reviewed
Nov 14, 2023
| } | ||
| } | ||
|
|
||
| export function getFastBridges<TransferType extends 'bridge' | 'swap'>({ |
There was a problem hiding this comment.
I get the point of having one function, but if we always know when we call which one we want, would not be better to have two function with clear naming? Unless we plan to add a new parameter later
There was a problem hiding this comment.
Maybe with a common helper function, but we would only export getFastSwaps, getFastBridges
|
obsolete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1055