Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix InboxTools method: GetForceIncludableBlockRange #520

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

FacuDeLorenzo
Copy link

Fixes decode of SequencerInbox: maxTimeVariaton contract call.

Removed failing accesor since maxTimeVariation returns a tuple, accesing the first value was breaking on runtime.

Copy link

cla-bot bot commented Jul 20, 2024

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign one of the linked documents below to get yourself added. If you're an independent Individual please sign this form: https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=1353a816-a9c1-47ba-847e-ec79f0f23d31&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2. If you're with a company (corporate) please sign this form: https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=2b5fe8ba-51d4-4980-b4ee-605d66e675d4&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2. To agree to the CLA license, please fill out one of the attached forms.

@wakeuplabs
Copy link

wakeuplabs commented Jul 24, 2024

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign one of the linked documents below to get yourself added. If you're an independent Individual please sign this form: https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=1353a816-a9c1-47ba-847e-ec79f0f23d31&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2. If you're with a company (corporate) please sign this form: https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=2b5fe8ba-51d4-4980-b4ee-605d66e675d4&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2. To agree to the CLA license, please fill out one of the attached forms.

Hi there,
WakeUp Labs has completed and submitted the required form to Offchain Labs as requested.

We look forward to your approval to proceed with the PR.
Thanks!!!

@hkalodner
Copy link
Contributor

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Jul 31, 2024
Copy link

cla-bot bot commented Jul 31, 2024

The cla-bot has been summoned, and re-checked this pull request!

@douglance
Copy link
Contributor

@FacuDeLorenzo could you pull in the latest from main to your branch so we can run our tests? thanks!

@FacuDeLorenzo
Copy link
Author

FacuDeLorenzo commented Aug 1, 2024

@FacuDeLorenzo could you pull in the latest from main to your branch so we can run our tests? thanks!

@douglance Done!

@dewanshparashar dewanshparashar self-requested a review August 2, 2024 09:30
@dewanshparashar
Copy link
Contributor

@FacuDeLorenzo The fix makes sense, but there are type issues with the fix causing the tests to fail. Please update the code to resolve these errors and ensure all tests pass.

@FacuDeLorenzo
Copy link
Author

FacuDeLorenzo commented Aug 2, 2024

I ended up casting the return value of the decoder, the ABI is generated from the contract defined on @arbitrum/nitro-contracts, but it's referencing to the version 1.1.0 (current is 2.1.0). So there's no way for me to correctly type the decoding.
I'm uploading 3 screenshots as proof, showing the type cast, debugging, and result of such debug against the contract on sepolia
image
image
image

Copy link

cla-bot bot commented Aug 12, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Facundo De Lorenzo.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot cla-bot bot removed the cla-signed label Aug 12, 2024
Copy link

cla-bot bot commented Aug 12, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Facundo De Lorenzo.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants