Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickstart Solidity Hardhad edits #688

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Quickstart Solidity Hardhad edits #688

merged 4 commits into from
Oct 17, 2023

Conversation

fionnachan
Copy link
Member

Changes

  • update deprecated command
    I got this on my console after initialising a project with yarn hardhat as mentioned on the docs. The command worked but it gives a warning.
    DEPRECATION WARNING
    
     Initializing a project with npx hardhat is deprecated and will be removed in the future.
     Please use npx hardhat init instead.
    
    now updated to yarn hardhat init
  • following the instructions, i ran into an error after running yarn hardhat compile, but i didn’t expect it because i didn’t read the next line. Updated the text to tell users that it is expected to fail before running the command.
  • MetaMask wallet import works with or without 0x prefix. Edited the instructions.

    Copy the private key of one of the test accounts (excluding the 0x prefix, so eg ac0..f80) and import it into Metamask:

  • Added additional dependencies installation instructions before first contract deployment.
    when i tried to deploy the smart contract locally, i faced an error:
    TypeError: (0 , ethers_1.getAddress) is not a function
    relevant stackoverflow issue:
    https://ethereum.stackexchange.com/questions/151234/followed-hardhat-test-tutorial-and-got-typeerror-0-ethers-1-getaddress-is
    turns out 4 months ago a new plugin is released by hardhat and is required for deploying contracts
    https://www.npmjs.com/package/hardhat-deploy-ethers
    after running yarn add --dev @nomicfoundation/hardhat-ethers ethers hardhat-deploy hardhat-deploy-ethers, the deployment was successful
  • couldn't test out the contract on the docs UI. reworked the React code to make it work both for web2 and web3 demos.
    image
  • replace markdown table with HTML to allow a table cell to span across multiple columns.

@cla-bot cla-bot bot added the s label Oct 17, 2023
@vercel
Copy link

vercel bot commented Oct 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nitro-docs ✅ Ready (Inspect) Visit Preview Oct 17, 2023 9:52am

@github-actions
Copy link

Hey there!
It looks like your changes are not well formatted. You can merge this PR, but we recommend to format your code with:

cd website && yarn format

Thanks!💙🧡

Copy link
Contributor

@symbolpunk symbolpunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOVE it! Thanks so much for contributing to docs @fionnachan!

@symbolpunk symbolpunk merged commit a2c0143 into master Oct 17, 2023
4 checks passed
@symbolpunk symbolpunk deleted the quickstart-edits branch October 17, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants