Generic SignatureCheck Verifier
#173
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Am I missing something, or can we just ditch the |
|
Yes, keeping the original Maybe it makes more sense to do this for something like RSA https://lib.rs/crates/rsa which really doesn't exist in Substrate's code. One potential problem is that the wallet uses sc-keystore, which only supports certain types of crypto not including RSA. So maybe the wallet just doesn't support rsa then; I guess that would be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
Verifierimplementation calledSignatureCheck. It is similar to the existingSr25519Signatureexcept that it is generic over Substrate's notion of cryptoPair.