Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exception option for inactive-windows-transparency.py #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

OctopusET
Copy link
Owner

#17 I made a mistake when I tried to merge this PR.

Thank you for your work @pzant

Copy link

@pzant pzant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@arpinux
Copy link

arpinux commented Mar 26, 2024

hi, perfect request!
testing the exception option with Gimp and it works perfectly with -o 0.80 -e no3d and for_window [class="Gimp"] mark --add no3d on sway config

thx a lot from a gimp lover! :D

@OctopusET
Copy link
Owner Author

@arpinux Thanks for testing, I didn't merge it because I found some bug. I will take a look at it soon and merge it.

@OctopusET OctopusET added help wanted Extra attention is needed good first issue Good for newcomers labels Apr 9, 2024
@pzant
Copy link

pzant commented May 22, 2024

@arpinux Thanks for testing, I didn't merge it because I found some bug. I will take a look at it soon and merge it.

As far as I remember, I'm removed this line

prev_workspace = workspace
to fix this bug #12
Perhaps this line in needed for a multi-monitor setup but in my case with single-monitor configuration it leads to an unpleasant bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants