Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to Apache-2.0 licence and add licence file to repository #122

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

geofflamrock
Copy link
Collaborator

@geofflamrock geofflamrock commented Dec 7, 2023

This PR changes the licence noted in package.json from ISC to Apache-2.0 to match our other public repositories and adds a licence file to the repository so it can be seen.

Fixes #119

How to review

  • Are there any concerns with the change of licence within package.json?
    • The original ISC licence really only came about by a default setting when creating the npm package.
    • The repository is very recent and has no forks currently, and this change aligns the licence usage with our other repositories, but not sure if there is anything else to be aware of here.
    • There also isn't any npm package that is published from this repo, so potentially no real impact in that regard.
  • Is it worth considering noting this change in release notes with a minor version bump?

@geofflamrock geofflamrock requested a review from a team as a code owner December 7, 2023 01:03
Copy link

changeset-bot bot commented Dec 7, 2023

⚠️ No Changeset found

Latest commit: ce77d98

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@geofflamrock geofflamrock changed the title Change to Apache-2.0 licence Change to Apache-2.0 licence and add licence file to repository Dec 7, 2023
Copy link

@dylanlerch dylanlerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the change is fine, but I also don't have any expertise, so won't be offended if you want a second opinion. 😄

@geofflamrock geofflamrock merged commit 3c4f159 into main Dec 7, 2023
6 checks passed
@geofflamrock geofflamrock deleted the geoffl/licence branch December 7, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add licence information
2 participants