fix: use total_seconds instead of seconds in the datetime #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using seconds is clearly a bug. Running
will print
13599 99999.0
. We would like99999
in our case.Also add more message in the log. Now it looks like
The calculation is based on the response time of downloading the first page. This log makes it clear that the estimated 40 seconds is calculated by 8 seconds/page * (6 - 1) page.
The estimated pages will still be inaccurate if the specified time span includes date range that has no data. This is unavoidable because it cannot be known in advance until the request is made. I found that when running the code below in QA. There are no data after 2019-11-27 for this device in QA.
Test failures in the Actions is caused by the multiple page bug in the server. It will be fixed in the next minor release from the server side.