issue-16: fix download bug in data product delivery

[IslaL]

Obtain and save data from response to avoid accessing the website again.

[KristenMeyerONC]

You can remove a level of nesting here by:

                    ext = util.extractFileExtension(filename);
                    if length(lengthData) == 1
                        this.fileSize = str2double(lengthData.Value);
                    elseif strcmp(ext, 'xml')
                        this.fileSize = length(xmlwrite(response.Body.Data));
                    else
                        this.fileSize = strlength(response.Body.Data);
                    end

[KristenMeyerONC]

Well that did not format well, one sec

[KristenMeyerONC]

Instead of this function you can use: https://www.mathworks.com/help/matlab/ref/fileparts.html which also handles string and char array.

[IslaL]

Oh this function is a perfect fit! I will update the codes

[IslaL]

The auto test shows that test Test09_ArchiveFiles/testDirectDownloadValidParamsMultiplePages failed when testing on Windows. It happened occasionally when i run the test locally, but it always fixed itself without any modifications. I just ran this test locally and it passed. I'm not sure if this has something to do with the server.

Error occurred in Test09_ArchiveFiles/testDirectDownloadValidParamsMultiplePages and it did not run to completion.
      ---------
      Error ID:
      ---------
      'MATLAB:dimagree'
      --------------
      Error Details:
      --------------
      Error using matlab.net.http.RequestMessage/sendOneRequest
      Matrix dimensions must agree.
      
      Error in matlab.net.http.RequestMessage/sendAfterChallenge (line 1674)
                      [response, request, history] = obj.sendOneRequest(connector, options, ...
      
      Error in matlab.net.http.RequestMessage/sendAndAuthenticate (line 1133)
                                         obj.sendAfterChallenge(response, connector, ...
      
      Error in matlab.net.http.RequestMessage/send (line 543)
                                   obj.sendAndAuthenticate([], completedURI, [], connector, options, ...
      
      Error in util.do_request (line 28)
          response = request.send(uri,options);
      
      Error in onc.OncArchive/getFile (line 65)
                      util.do_request(url, filters, 'timeout', this.timeout, 'showInfo', this.showInfo, ...
      
      Error in onc.OncArchive/getDirectFiles (line 161)
                          downInfo = this.getFile(filename, overwrite, 'showMsg', false);
      
      Error in Test09_ArchiveFiles/testDirectDownloadValidParamsMultiplePages (line 178)
                  result = this.onc.getDirectFiles(this.paramsLocationMultiPages);
      
      Caused by:
          Error using /
          Matrix dimensions must agree.

[IslaL]

Just re-ran the windows auto test and it passed.