issue-14: fixed minor bugs found when testing #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristenMeyerONC
requested changes
Apr 9, 2024
onc/+onc/DataProductFile.m
Outdated
| @@ -101,31 +99,43 @@ | |||
| this.fileSize = strlength(response.Body.Data); | |||
| end | |||
| %save_as_file doesn't work properly! Use urlwrite instead | |||
| [~, saveResult] = urlwrite(uri.EncodedURI,fullfile(outPath, filename)); | |||
| %saveResult = util.save_as_file(response, outPath, filename, overwrite); | |||
| %[~, saveResult] = urlwrite(uri.EncodedURI,fullfile(outPath, filename)); | |||
There was a problem hiding this comment.
You can remove this commented code
onc/+onc/DataProductFile.m
Outdated
| this.status = 777; | ||
| end | ||
| elseif s == 202 | ||
| % Still processing, wait and retry | ||
| log.printResponse(jsondecode(response.Body.Data)); | ||
| %log.printResponse(response.Body.Data); |
onc/+onc/DataProductFile.m
Outdated
| [~, saveResult] = urlwrite(uri.EncodedURI,fullfile(outPath, filename)); | ||
| %saveResult = util.save_as_file(response, outPath, filename, overwrite); | ||
| %[~, saveResult] = urlwrite(uri.EncodedURI,fullfile(outPath, filename)); | ||
| % neither urlwrite nor save_as_file works properly, use websave |
There was a problem hiding this comment.
Can you update this comment to make it in line with the comment on line 101?
101 says to use urlwrite, then this says not to use urlwrite
There was a problem hiding this comment.
Sure! I forgot the commented lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bugs found when testing with new test suites. Descriptions of each bug is in: #14
Bugs found in OncDelivery will be fixed together later with download issue