-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added credential and related terms #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The one thing I notice is that content appears to be missing from occo-edit. When I open it, I can't find any of the terms from occo_terms, along with 'document', 'organization', 'employer role', and 'social act'.
These terms are imported from different external ontologies, you can find them in IAO_imports.owl, OBI_imports.owl and OMRSE_imports.owl. Total 12 files including 4 OWL files were changed and 3 new OWL files added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some definitions and labels in the submitted version of the paper are different. When you change these, would you mind also changing terminology in the .tsv file accordingly?
I updated the labels and definitions based on the OccO paper Finn sent to me. The definition of 'occupational credential holder' is 'An organism that an occupation credential is about.'. I did not change its parent from 'Homo sapiens' to 'organism' since we have not imported 'organism' in OccO yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still unsure of whether the occo-edit is missing terms, but we can see if that's the case after the changes are approved and add them afterwards if they're missing
Import 'employer role' from OMRSE
Added following terms:
OCCO:00000118 credential, issue: #31
OCCO:00000119 occupational credential
OCCO:00000120 credential granting agency
OCCO:00000121 competence, issue: #29
OCCO:00000122 occupational credential holder
OCCO:00000123 certificate
OCCO:00000124 certification
OCCO:00000125 academic degree
OCCO:00000126 license
OCCO:00000127 credential grantor role
OCCO:00000128 credential issuing process
OCCO:00000129 quality assurance group
OCCO:00000130 accredited by