-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ObolValidatorManager #154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay looking super good so far.
the thing i asked some questions on was the principalThreshold, i do think we spend some time there, particularly figuring out how we get operators paid. Maybe a time of requestRewardWithdrawal that can only pull less than threshold and has a separate role?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double approve
Summary
In according to the updated design doc:
deposit()
proxy call and changed logic around principal amount withdrawal,Clone
functionality,requestWithdrawal
to accept amounts >=principalThreshold
,requestConsolidation
to accept at most 63 source pubkeys,Details
Please refer to the internal design doc for further details.
How to test it
forge test
ticket: #152