Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ObolValidatorManager #154

Merged
merged 6 commits into from
Feb 6, 2025
Merged

feat: ObolValidatorManager #154

merged 6 commits into from
Feb 6, 2025

Conversation

pinebit
Copy link
Contributor

@pinebit pinebit commented Feb 4, 2025

Summary

In according to the updated design doc:

  • introduced deposit() proxy call and changed logic around principal amount withdrawal,
  • removed the Clone functionality,
  • restricted requestWithdrawal to accept amounts >= principalThreshold,
  • restricted requestConsolidation to accept at most 63 source pubkeys,
  • adjusted tests to cover the new features.

Details

Please refer to the internal design doc for further details.

How to test it

forge test

ticket: #152

@pinebit pinebit requested a review from OisinKyne February 4, 2025 10:46
@pinebit pinebit changed the title fix: broken tests (#151) feat: OWRv2 with deposit proxy Feb 4, 2025
@pinebit pinebit marked this pull request as ready for review February 5, 2025 06:57
Copy link
Contributor

@OisinKyne OisinKyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay looking super good so far.

the thing i asked some questions on was the principalThreshold, i do think we spend some time there, particularly figuring out how we get operators paid. Maybe a time of requestRewardWithdrawal that can only pull less than threshold and has a separate role?

@pinebit pinebit changed the title feat: OWRv2 with deposit proxy feat: ObolValidatorManager Feb 6, 2025
Copy link
Contributor

@OisinKyne OisinKyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double approve

@pinebit pinebit merged commit 3bfde7b into release/v0.2 Feb 6, 2025
1 check passed
@OisinKyne OisinKyne deleted the pinebit/owr-deposit branch February 13, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants