cmd: fetch and broadcast all when not all are activated #3489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3489 +/- ##
==========================================
+ Coverage 57.37% 57.39% +0.01%
==========================================
Files 217 217
Lines 32238 32245 +7
==========================================
+ Hits 18498 18506 +8
Misses 11829 11829
+ Partials 1911 1910 -1 ☔ View full report in Codecov by Sentry. |
KaloyanTanev
force-pushed
the
kalo/fix-subset-exit-all
branch
from
76e717e to
a41a92f
Compare
|
DiogoSantoss
approved these changes
Jan 31, 2025
pinebit
approved these changes
Jan 31, 2025
KaloyanTanev
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the scenario where not all keys are activated, fetching and broadcasting from the obol API wasn't possible. This PR fixes this and only throws an error if a key hasn't exited.
category: bug
ticket: none