Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/consensus: change exponential timer for linear timer #3470

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

DiogoSantoss
Copy link
Contributor

Change exponential timer (implemented in #3440) for linear timer.

  • First consensus round has 1 second to complete
  • Subsequent rounds have linearly more time starting at 400ms (600ms, 800ms, 1s, etc...)

category: refactor
ticket: #3430
feature_flag: linear

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.94%. Comparing base (081e4bc) to head (ba416b2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3470      +/-   ##
==========================================
- Coverage   56.98%   56.94%   -0.05%     
==========================================
  Files         218      218              
  Lines       32519    32524       +5     
==========================================
- Hits        18532    18521      -11     
- Misses      12088    12098      +10     
- Partials     1899     1905       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@KaloyanTanev KaloyanTanev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but we might want to come up with better name than linear. Something that describes the feature better.

@DiogoSantoss DiogoSantoss added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jan 20, 2025
@obol-bulldozer obol-bulldozer bot merged commit 164dee0 into main Jan 20, 2025
13 checks passed
@obol-bulldozer obol-bulldozer bot deleted the diogo/linear-consensus-timer branch January 20, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants