Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle optional variable LOGICAL_BACKUP_S3_ENDPOINT #20

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Conversation

nihaldivyam
Copy link
Collaborator

@nihaldivyam nihaldivyam commented Jul 19, 2024

Description

This PR addresses an issue where the script would fail if the LOGICAL_BACKUP_S3_ENDPOINT variable was not set. Since LOGICAL_BACKUP_S3_ENDPOINT is an optional variable, the script has been modified to handle its unset state gracefully.

Changes

Added a default value for LOGICAL_BACKUP_S3_ENDPOINT to ensure it is defined even if it is empty.

@nihaldivyam nihaldivyam marked this pull request as ready for review July 19, 2024 16:12
@nihaldivyam nihaldivyam requested a review from ashish1099 July 19, 2024 16:15
@ashish1099 ashish1099 merged commit 7c7e557 into main Jul 22, 2024
1 check passed
@ashish1099 ashish1099 deleted the v1.0.5 branch July 22, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants