Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typos): Possibly all typos in plugin #275

Merged
merged 3 commits into from
Jan 31, 2025
Merged

Conversation

MuntasirSZN
Copy link
Contributor

This pull request includes several minor corrections and formatting changes across multiple files. The primary focus is on fixing typos and ensuring consistency in the documentation and codebase.

Typo Corrections:

Formatting Changes:

Subproject Update:

Edit: Generated with copilot, I am lazy.

Please check for any problems, i only fixed typos with typos cli (not --write, checking the output and fixing one by one).

@OXY2DEV
Copy link
Owner

OXY2DEV commented Jan 31, 2025

__emoji_link_compatibility

That's not a typo. The option was previously called that and I never bothered fixing it.

@MuntasirSZN
Copy link
Contributor Author

__emoji_link_compatibility

That's not a typo. The option was previously called that and I never bothered fixing it.

Ok reverting.

fix(typo): the compatability should be the same
@MuntasirSZN
Copy link
Contributor Author

Anything else?

@MuntasirSZN MuntasirSZN requested a review from OXY2DEV January 31, 2025 17:05
@OXY2DEV OXY2DEV merged commit 02b5206 into OXY2DEV:main Jan 31, 2025
1 check passed
@OXY2DEV
Copy link
Owner

OXY2DEV commented Jan 31, 2025

Thanks for the PR!

@MuntasirSZN
Copy link
Contributor Author

Thanks for the PR!

Isn't the submodules messed up? @OXY2DEV

@OXY2DEV
Copy link
Owner

OXY2DEV commented Jan 31, 2025

I have run a check with aspell on the wiki submodule and. Couldn't find any actual spelling errors.

So, I am assuming the sub-module got properly merged.

@MuntasirSZN
Copy link
Contributor Author

I have run a check with aspell on the wiki submodule and. Couldn't find any actual spelling errors.

So, I am assuming the sub-module got properly merged.

There were changes, sir. See the word Uncheked? And 'miliseconds'? @OXY2DEV I think i should make another pr. My third commit that came with the pr 'message had the word weird', messed up the submodules. Try to drop and force push maybe, or wait for my pr.

@OXY2DEV
Copy link
Owner

OXY2DEV commented Feb 1, 2025

I have checked for both and I couldn't find them.

@MuntasirSZN
Copy link
Contributor Author

I have checked for both and I couldn't find them.

Ok, I will check anyways.

@MuntasirSZN
Copy link
Contributor Author

MuntasirSZN commented Feb 1, 2025

Nah all good, but why its cheked in github ui wiki still? @OXY2DEV Sorry for ping.

@OXY2DEV
Copy link
Owner

OXY2DEV commented Feb 1, 2025

Doesn't really matter.

The typos aren't in the repo and that's all that matters.

@MuntasirSZN
Copy link
Contributor Author

Doesn't really matter.

The typos aren't in the repo and that's all that matters.

Ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants