Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (5) MASWE-PRIVACY #2860

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

annab-google
Copy link

Thank you for submitting a Pull Request to the OWASP MASTG. Please make sure that:

  • Your contribution is written in the 2nd person (e.g. you)
  • Your contribution is written in an active present form for as much as possible.
  • You have made sure that the reference section is up to date (e.g. please add sources you have used, make sure that the references to MITRE/MASVS/etc. are up to date)
  • Your contribution has proper formatted markdown and/or code
  • Any references to website have been formatted as [TEXT](URL “NAME”)
  • You verified/tested the effectiveness of your contribution (e.g.: is the code really an effective remediation? Please verify it works!)

If your PR is related to an issue. Please end your PR test with the following line:
This PR closes #< insert number here >.

@annab-google annab-google changed the title Add (5) MASVS-PRIVACY Add (5) MASWE-PRIVACY Aug 2, 2024
@annab-google
Copy link
Author

Hi @cpholguera, please see Privacy weakness by Google` WG.

@cpholguera
Copy link
Collaborator

This is awesome, we'll review this soon!

Thanks a lot @annab-google and to the whole WG!

spelling fix
Copy link
Collaborator

@TheDauntless TheDauntless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly grammar changes, apart from the copy-paste issue.

weaknesses/MASVS-PRIVACY/MASWE-0109.md Outdated Show resolved Hide resolved
weaknesses/MASVS-PRIVACY/MASWE-0110.md Outdated Show resolved Hide resolved
weaknesses/MASVS-PRIVACY/MASWE-0110.md Outdated Show resolved Hide resolved
weaknesses/MASVS-PRIVACY/MASWE-0110.md Outdated Show resolved Hide resolved
weaknesses/MASVS-PRIVACY/MASWE-0110.md Outdated Show resolved Hide resolved
weaknesses/MASVS-PRIVACY/MASWE-0113.md Outdated Show resolved Hide resolved
weaknesses/MASVS-PRIVACY/MASWE-0113.md Outdated Show resolved Hide resolved
weaknesses/MASVS-PRIVACY/MASWE-0113.md Outdated Show resolved Hide resolved
weaknesses/MASVS-PRIVACY/MASWE-0113.md Show resolved Hide resolved
weaknesses/MASVS-PRIVACY/MASWE-0109.md Outdated Show resolved Hide resolved
@annab-google
Copy link
Author

Addressed comments.

Copy link
Collaborator

@sushi2k sushi2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @annab-google ! This is a really great contribution. I've got a few small things, please have a look.

weaknesses/MASVS-PRIVACY/MASWE-0109.md Outdated Show resolved Hide resolved
weaknesses/MASVS-PRIVACY/MASWE-0111.md Outdated Show resolved Hide resolved
weaknesses/MASVS-PRIVACY/MASWE-0112.md Outdated Show resolved Hide resolved
@annab-google
Copy link
Author

Thank you for review @TheDauntless and @sushi2k! Let me know if anything else is pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants