Adding print postfix for print formatting. #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM.
sydseter
changed the title
|
This can be merged now too thanks to the updated CODEOWNERS @sydseter |
|
Great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull-request:
@cw-owasp Jef Mejivis and me are working on the new cornucopia website. https://cornucopia-mvp.vercel.app/
We want to be able to pull the mapping data directly from OWASP/cornucopia to build urls that can take the user to information about the ASVS requirements etc. In order to be able to parse the data in the simple way, it would be great if we can fetch the references without the dash used as a range as that requires quite a bit of logic on the backend to parse and interpret. I have therefor added an additional postfix "_print" property, where appropriate, to ensure that the cards that are printed still shows the requirement map as a range where notated.
I also fixes some issues that was left after we corrected the (C) cornucopia card codes and have ensured that both the 1.22 and 2.00 version aligns in regards to the new _print postfix "property".
It's unlikely that this property will be used outside this repository, this way, the code for parsing will be easier to maintain. It will simplify the input validation as well and will make consumption of the data outside the repository easier.