-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/192 #197
Draft
sher04lock
wants to merge
43
commits into
OWASP:feature/192
Choose a base branch
from
sher04lock:feature/192
base: feature/192
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Feature/192 #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added Husky - Added main tasks as mirror (all:* and server-render:* patterns)
- Related OWASP#192 ``` cookie-parser ~1.4.4 → ~1.4.5 debug ~2.6.9 → ~4.1.1 express ~4.16.1 → ~4.17.1 http-errors ~1.6.3 → ~1.7.3 morgan ~1.9.1 → ~1.10.0 ```
- Related OWASP#192 - Added depedency `[email protected]` - Added main config file
- Related OWASP#192 - Added dev dependency `[email protected]` - Added npm tasks for linting
- Related OWASP#192 - Added dev dependencies `[email protected]` & `[email protected]` - Added npm tasks for testing
- Updated testing dependencies ``` @testing-library/jest-dom ^4.2.4 → ^5.1.1 @testing-library/react ^9.3.2 → ^10.0.1 @testing-library/user-event ^7.1.2 → ^10.0.0 ```
- Added jest to eslint rules - Linted files
- Related OWASP#192 - Added watch and CI support - Missing coverage and snapshot update
@sher04lock great progress! I will review and get back to you if any early feedback. Thanks for the WIP PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion in #194 I've forked branch from @KoolTheba and started working on implementing new endpoints and examples of vulnerabilities.
This Pull Request is still WIP.
It was created to allow reviewers gradually review and comment on new changes, as there will be a lot of them.
For now, new API application includes:
express-session
POST /api/v1/login
GET /api/v1/profile
PUT /api/v1/profile/:id
GET /api/v1/allocations/:userId
Each implemented vulnerability includes tests for checking:
Vulnerabilities implemented:
If I implement new endpoints before this PR gets merged, I'll include them as part of this PR.