-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated card component to chakraUI #631
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me!
At what phase you think we'll be able to remove tailwindcss stuff?
If we are thinking to remove tailwind then lets go component by component and for every migration of component we will be able to achieve the end goal of removing tailwind, i can make changes in this PR if we really want to move away from tailwind |
No, no action required. It was just a general question, no rush. |
okay sure then lets take baby steps towards the migration, lets first migrate the components, if we are sure that we can move out of tailwind completely (which is a bit difficult), we will do it then, till then we can migrate components step by step |
@arkid15r made the necessary changes, you can review it now :) |
Hi @Dishant1804, in this PR, we are using the Tooltip from Chakra instead of react-tooltip. Can we remove the react-tooltip dependency from package.json? |
@Rajgupta36 no sadly we cannot do it as of now in this PR, as other components are still dependent on the react-tooltip the issue #645 addresses this, i've looked into it there |
ohk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging this in, LGTM 👍
Resolves #575
This PR migrates the card component to chakraUI, also the test cases for the same are modified