Addition of Contribute Section in Home of Slack NestBot #593
Conversation
There was a problem hiding this comment.
Good work but it seems you've overdone it a bit.
We already have Issue entity in the index which is essentially a building block for Contribute page.
The tasks' aim here was to reuse slack/commands/contribute.py code by refactoring it into a shared handler similar to chapters.
BTW here @nitinawari suggested the right approach to solve this.
Please remove redundant functionality and owasp app API changes while keeping essential changes only.
|
Ok i'll do it |
There was a problem hiding this comment.
hey @AbhayTopno,
Great work! I can see the effort you've put in, but it seems like there was a slight misunderstanding of the original issue.
When you have time, please check out these suggestions:
I understand what you did — you created a new entity in apps/owaspas Contributor. However, we don’t need to create a new one. We already have issue entities in apps/github. Please use those instead.
You can refer to this comment for the actual steps to resolve this.
Hints for you:
-
You don’t need to make any changes outside of
apps/slack. -
This is not related to this PR, but please make sure to create a separate branch for your PRs in the future, rather than pushing directly to the main branch. don't close this PR until get merged
I hope these comments and suggestions help you resolve the issue.
Thank you!
|
Thanks for the correction. I'll make the changes as you suggested, and sorry for the trouble I'm causing @nitinawari |
|
Hey @AbhayTopno, no need to apologize for anything. We’re all in the learning phase. 👍 If you need any help, feel free to reach out to me on Slack DM. I’ll be happy to assist. |
|
@nitinawari thanks for helping with reviews! |
|
@arkid15r @nitinawari I have made the changes as you both suggested Let me know if anything is incorrect or needs further adjustment. |
Co-authored-by: Nitin Awari <[email protected]>
|
@nitinawari Thanks a lot for helping me! I’ve learned so much from this @arkid15r Let me know if there are any changes you want to make |
|
@arkid15r I have made the changes |
* Addition of Contribute Section in Home of Slack NestBot * Update contribute.py * Update of apps/slack/commands/contribute * Minor changes * Update of code after the review * Update backend/apps/slack/commands/contribute.py Co-authored-by: Nitin Awari <[email protected]> * Update urls.py * Update contribute.py * Update code --------- Co-authored-by: Nitin Awari <[email protected]> Co-authored-by: Arkadii Yakovets <[email protected]> Co-authored-by: Arkadii Yakovets <[email protected]>
* anchor tags migrated * Buttons migrated to chakraUI * migarted buttons tooltip and anchortags to chakraUI * fixed focus ring issue * Generic component for details page (#678) * base_design * Add types and apply corrections. * Improvement * cleanup * added issue label * fixes * pre-commit --------- Co-authored-by: Kate Golovanova <[email protected]> * Addition of Contribute Section in Home of Slack NestBot (#593) * Addition of Contribute Section in Home of Slack NestBot * Update contribute.py * Update of apps/slack/commands/contribute * Minor changes * Update of code after the review * Update backend/apps/slack/commands/contribute.py Co-authored-by: Nitin Awari <[email protected]> * Update urls.py * Update contribute.py * Update code --------- Co-authored-by: Nitin Awari <[email protected]> Co-authored-by: Arkadii Yakovets <[email protected]> Co-authored-by: Arkadii Yakovets <[email protected]> * resolved conflicts * sort dropdown tooltip position modified * test utils warpper used * checks and format * removed unnecessary button props * removed redundant lines * Update FE dependencies * tooltip-bug (#744) * Addition of website attribute to project schema (#740) * Addition of website attribute to project schema * Update vite.config.ts * Update website-empty.yaml * Update website-none.yaml * Update website-none.yaml * Update website-empty.yaml * Update website-none.yaml * Update website-empty.yaml * Update website-empty.yaml * Update project_test.py * Update project.json * Delete schema/tests/data/project/negative/website-empty.yaml * Update code --------- Co-authored-by: Arkadii Yakovets <[email protected]> Co-authored-by: Arkadii Yakovets <[email protected]> * Add blog to project schema (#745) * added blog attribute to project schema * added blog attribute * Update project_test.py * Update code * Update code --------- Co-authored-by: Arkadii Yakovets <[email protected]> * Initialize OWASP chapter schema * Refactor index synonyms (#748) * Changes5 * Refactor index synonyms * Update code --------- Co-authored-by: Raghav Gupta 2 <[email protected]> Co-authored-by: Arkadii Yakovets <[email protected]> * write repository schema and tests (#741) * write repository schema and tests * fixed repository schema tests * Update code --------- Co-authored-by: Arkadii Yakovets <[email protected]> * Fetch /gsoc command data from Algolia instead of DB (#712) * gsoc command data fetch from algolia * pre-commit and format checks * moved get_gsoc_projects to search project file * Update code --------- Co-authored-by: Arkadii Yakovets <[email protected]> Co-authored-by: Arkadii Yakovets <[email protected]> * Reconfigure spell check * Bump @chakra-ui/react from 3.6.0 to 3.7.0 in /frontend (#752) Bumps [@chakra-ui/react](https://github.com/chakra-ui/chakra-ui/tree/HEAD/packages/react) from 3.6.0 to 3.7.0. - [Release notes](https://github.com/chakra-ui/chakra-ui/releases) - [Changelog](https://github.com/chakra-ui/chakra-ui/blob/main/packages/react/CHANGELOG.md) - [Commits](https://github.com/chakra-ui/chakra-ui/commits/@chakra-ui/[email protected]/packages/react) --- updated-dependencies: - dependency-name: "@chakra-ui/react" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update params mapping * Added a method to convert block to text and fixed warning (#754) * Added a method to convert block to text * Added testcase for utils * Update code --------- Co-authored-by: Arkadii Yakovets <[email protected]> Co-authored-by: Arkadii Yakovets <[email protected]> * Update frontend dependencies * Run poetry update * conflicts resolved * Cleanup: removing unused dependencies n dev dependencies (#601) * "Cleanup: removing unused dependencies n dev dependencies " * resolved conflicts * Fix staging image build * "Cleanup: removing unused dependencies n dev dependencies " * fix run npm install install prettier plugin tailwindcss * fix run run npm lint check * fix check for uncommited changes * resolved conflicts n npm format check * "Cleanup: removing unused dependencies n dev dependencies " * resolved conflicts * Fix staging image build * "Cleanup: removing unused dependencies n dev dependencies " * fix run npm install install prettier plugin tailwindcss * fix run run npm lint check * fix check for uncommited changes * resolved conflicts n npm format check * updated one * updated fix * removed unwanted files from updated fix * Update code --------- Co-authored-by: Arkadii Yakovets <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Kate Golovanova <[email protected]> Co-authored-by: Raj gupta <[email protected]> Co-authored-by: AbhayTopno <[email protected]> Co-authored-by: Nitin Awari <[email protected]> Co-authored-by: Arkadii Yakovets <[email protected]> Co-authored-by: Arkadii Yakovets <[email protected]> Co-authored-by: yashgoyal0110 <[email protected]> Co-authored-by: Rusheek <[email protected]> Co-authored-by: Raghavg18 <[email protected]> Co-authored-by: Raghav Gupta 2 <[email protected]> Co-authored-by: Shyam Kumar <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Abhay <[email protected]> Co-authored-by: Diamond Girl <[email protected]>
Finished adding the Contribute section to the home of Slack NestBot. If there are any conflicts, feel free to reach out to me