-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve project details recent issue block #579
Conversation
Is this #561 duplicate? |
Yess @arkid15r Actually there is some issue with the branch so i need to make a new branch |
Okay, resolve it locally and update the PR. You created a new PR instead. |
@arkid15r actually i tried to update the PR but the old branch was giving issues so i made a new Branch Sorry For the inconvenience |
/> | ||
<span className="text-sm">{issue.author.name}</span> | ||
<a | ||
href={`https://github.com/${issue.author.key}`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link should point to the OWASP Nest user's community page
![]() @arkid15r i am getting this error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- please update these branch to the base branch.
- The tests are failing because you modified the
ProjectDetailsPage
functionality. Kindly update the tests to reflect these changes.
1c80f79
to
a8cd530
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issues and releases always empty when I check it locally.
@Raghavg18 regenrate api key from algolia and then re-run |
![]() |
@Raghavg18 change region from eu to us |
@nitinawari still not working |
@Raghavg18 then create new app in that account and use that api keys , if not solved then DM on slack |
@nitinawari ig its still not working so i will have to connect with u |
@Raghavg18 hey for now go to the your algolia dashboard and delete this indices |
Done @nitinawari |
what should i do now @nitinawari ? |
@Raghavg18 now run the |
@arkid15r fetched data don't contain username and issue number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR needs to be synced with the recent changes. Please let me know if you're still interested in working on this
Yes @arkid15r working on it |
Alright, I've set a deadline for this to Feb 12. |
@arkid15r fetched data don't contain username and issue number still facing the same issue with this ? |
@arkid15r I want to give my opinion for this issue, We can not make the issue clickable but can make the the github account of the user clickable. After going through the code thoroughly I came to a conclusion that graphql is only providing issue name, assigned by and such type of things but not the issue.key. So, If you want I can merge a PR of clickable github account |
@moodyadi2006 you can take over this issue as its deadline has already passed. We can get any data we have in the DB via graphql so both user and issue could be clickable as far as I understand. |
Sorry @arkid15r i tried but the fetched data was not coming |
Resolves #551
Add links to users and issue and made it clickable