Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve project details recent issue block #579

Closed
wants to merge 12 commits into from

Conversation

Raghavg18
Copy link
Contributor

Resolves #551
Add links to users and issue and made it clickable

@arkid15r
Copy link
Collaborator

Is this #561 duplicate?

@Raghavg18
Copy link
Contributor Author

Yess @arkid15r Actually there is some issue with the branch so i need to make a new branch

@arkid15r
Copy link
Collaborator

Yess @arkid15r Actually there is some issue with the branch so i need to make a new branch

Okay, resolve it locally and update the PR. You created a new PR instead.

@Raghavg18
Copy link
Contributor Author

@arkid15r actually i tried to update the PR but the old branch was giving issues so i made a new Branch Sorry For the inconvenience

/>
<span className="text-sm">{issue.author.name}</span>
<a
href={`https://github.com/${issue.author.key}`}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link should point to the OWASP Nest user's community page

@Raghavg18
Copy link
Contributor Author

Screenshot 2025-01-25 at 2 13 46 AM

@arkid15r i am getting this error

@Raghavg18 Raghavg18 requested a review from arkid15r January 25, 2025 12:56
Copy link
Collaborator

@nitinawari nitinawari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Raghavg18,

  • please update these branch to the base branch.
  • The tests are failing because you modified the ProjectDetailsPage functionality. Kindly update the tests to reflect these changes.

@Raghavg18 Raghavg18 force-pushed the Block2 branch 2 times, most recently from 1c80f79 to a8cd530 Compare January 27, 2025 15:54
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issues and releases always empty when I check it locally.

@Raghavg18
Copy link
Contributor Author

Screenshot 2025-01-28 at 1 54 11 AM

i am getting this error while making index command

@nitinawari
Copy link
Collaborator

@Raghavg18 regenrate api key from algolia and then re-run make load-data and make index-data

@Raghavg18
Copy link
Contributor Author

Screenshot 2025-01-30 at 2 13 58 PM i regenerated the api key But still showing the same error @arkid15r @nitinawari

@nitinawari
Copy link
Collaborator

@Raghavg18 change region from eu to us

@Raghavg18
Copy link
Contributor Author

@nitinawari still not working

@nitinawari
Copy link
Collaborator

nitinawari commented Jan 30, 2025

@Raghavg18 then create new app in that account and use that api keys , if not solved then DM on slack

@Raghavg18
Copy link
Contributor Author

@nitinawari ig its still not working so i will have to connect with u

@nitinawari
Copy link
Collaborator

nitinawari commented Jan 31, 2025

@Raghavg18 hey for now go to the your algolia dashboard and delete this indices
image

@Raghavg18
Copy link
Contributor Author

Done @nitinawari
i deleted it

@Raghavg18
Copy link
Contributor Author

what should i do now @nitinawari ?

@nitinawari
Copy link
Collaborator

@Raghavg18 now run themake index-data

@nitinawari nitinawari mentioned this pull request Feb 3, 2025
@Raghavg18
Copy link
Contributor Author

@arkid15r fetched data don't contain username and issue number

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs to be synced with the recent changes. Please let me know if you're still interested in working on this

@arkid15r arkid15r marked this pull request as draft February 8, 2025 18:56
@Raghavg18
Copy link
Contributor Author

Yes @arkid15r working on it

@arkid15r
Copy link
Collaborator

Yes @arkid15r working on it

Alright, I've set a deadline for this to Feb 12.

@Raghavg18
Copy link
Contributor Author

@arkid15r fetched data don't contain username and issue number still facing the same issue with this ?

@moodyadi2006
Copy link
Contributor

@arkid15r I want to give my opinion for this issue, We can not make the issue clickable but can make the the github account of the user clickable. After going through the code thoroughly I came to a conclusion that graphql is only providing issue name, assigned by and such type of things but not the issue.key. So, If you want I can merge a PR of clickable github account

@arkid15r
Copy link
Collaborator

@arkid15r I want to give my opinion for this issue, We can not make the issue clickable but can make the the github account of the user clickable. After going through the code thoroughly I came to a conclusion that graphql is only providing issue name, assigned by and such type of things but not the issue.key. So, If you want I can merge a PR of clickable github account

@moodyadi2006 you can take over this issue as its deadline has already passed. We can get any data we have in the DB via graphql so both user and issue could be clickable as far as I understand.
Go ahead and submit PR if you solved this issue @moodyadi2006

@Raghavg18
Copy link
Contributor Author

Sorry @arkid15r i tried but the fetched data was not coming

@arkid15r arkid15r closed this Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve project details recent issue block
4 participants