Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return ASAP after handling finalizer #940

Merged
merged 1 commit into from
May 22, 2024

Conversation

drivebyer
Copy link
Collaborator

Description

Fixes #801

After we update the resource, we should return as soon as possible. Otherwise, we will get a conflict error when doing the next update.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

@drivebyer drivebyer added the bug Something isn't working label May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 5.88235% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 38.96%. Comparing base (d121d86) to head (1e53480).
Report is 52 commits behind head on master.

Files Patch % Lines
controllers/redis_controller.go 0.00% 3 Missing and 1 partial ⚠️
controllers/rediscluster_controller.go 20.00% 3 Missing and 1 partial ⚠️
controllers/redisreplication_controller.go 0.00% 3 Missing and 1 partial ⚠️
controllers/redissentinel_controller.go 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #940      +/-   ##
==========================================
+ Coverage   35.20%   38.96%   +3.76%     
==========================================
  Files          19       20       +1     
  Lines        3213     2728     -485     
==========================================
- Hits         1131     1063      -68     
+ Misses       2015     1594     -421     
- Partials       67       71       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drivebyer drivebyer merged commit d15c80e into OT-CONTAINER-KIT:master May 22, 2024
28 of 29 checks passed
mattrobinsonsre pushed a commit to mattrobinsonsre/redis-operator that referenced this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when deleting redis cr resource
1 participant