Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add common AddFinalizer for all api #858

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

drivebyer
Copy link
Collaborator

Description

Add common AddFinalizer for all api

Type of change

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

@drivebyer drivebyer requested a review from shubham-cmyk April 1, 2024 07:18
@drivebyer drivebyer enabled auto-merge (squash) April 1, 2024 07:18
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.63%. Comparing base (d121d86) to head (bc26ef6).
Report is 21 commits behind head on master.

❗ Current head bc26ef6 differs from pull request most recent head 5e60431. Consider uploading reports for the commit 5e60431 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #858      +/-   ##
==========================================
+ Coverage   35.20%   38.63%   +3.43%     
==========================================
  Files          19       19              
  Lines        3213     2632     -581     
==========================================
- Hits         1131     1017     -114     
+ Misses       2015     1547     -468     
- Partials       67       68       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Shubham Gupta <[email protected]>
Copy link
Member

@shubham-cmyk shubham-cmyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

It remove the unnecessary code

@drivebyer drivebyer merged commit 86945fc into OT-CONTAINER-KIT:master Apr 1, 2024
25 checks passed
@drivebyer drivebyer deleted the refac-finalizer branch April 2, 2024 02:05
mattrobinsonsre pushed a commit to mattrobinsonsre/redis-operator that referenced this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants