fix: ensure sentinel does not observes the failover progress in replication cluster #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #803 +/- ##
==========================================
+ Coverage 35.20% 35.73% +0.52%
==========================================
Files 19 19
Lines 3213 2628 -585
==========================================
- Hits 1131 939 -192
+ Misses 2015 1621 -394
- Partials 67 68 +1 ☔ View full report in Codecov by Sentry. |
shubham-cmyk
added
the
temp-fix
|
This PR needs #806 to be merged first because when one applies the sentinel first, the sentinel will be monitoring an empty Redis replication cluster. |
drivebyer
force-pushed
the
fix-sentinel-restart
branch
from
e65282e to
083118f
Compare
|
@shubham-cmyk it's ready now plz. |
…cation cluster Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
drivebyer
force-pushed
the
fix-sentinel-restart
branch
from
36cc0ee to
8d36f11
Compare
mattrobinsonsre
pushed a commit
to mattrobinsonsre/redis-operator
that referenced
this pull request
Jul 11, 2024
…cation cluster (OT-CONTAINER-KIT#803) * fix: ensure sentinel does not observes the failover progress in replication cluster Signed-off-by: drivebyer <[email protected]> * add e2e Signed-off-by: drivebyer <[email protected]> * enhance check Signed-off-by: drivebyer <[email protected]> * check master through sentinel Signed-off-by: drivebyer <[email protected]> --------- Signed-off-by: drivebyer <[email protected]> Signed-off-by: drivebyer <[email protected]> Signed-off-by: Matt Robinson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #802.
Fix #778 .
It's acceptable to extend the RequeueAfter period for reconciliation, as the operations performed during this process are limited and primarily involve creating the sentinel StatefulSet and associated services.
Type of change
Checklist
Additional Context