Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add secret_test.go #701

Merged
merged 5 commits into from
Nov 10, 2023
Merged

Conversation

shubham-cmyk
Copy link
Member

part of : #656

Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: Shubham Gupta <[email protected]>
Copy link

gitguardian bot commented Nov 10, 2023

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
- Generic Private Key 978de66 tests/testdata/secrets/tls.key View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 135 lines in your changes are missing coverage. Please review.

Files Coverage Δ
controllers/redissentinel_controller.go 0.00% <0.00%> (ø)
controllers/redisreplication_controller.go 0.00% <0.00%> (ø)
k8sutils/status.go 0.00% <0.00%> (ø)
k8sutils/redis-sentinel.go 30.88% <27.27%> (-0.18%) ⬇️
k8sutils/secrets.go 74.11% <73.33%> (+74.11%) ⬆️
controllers/rediscluster_controller.go 0.00% <0.00%> (ø)
k8sutils/cluster-scaling.go 0.00% <0.00%> (ø)
k8sutils/redis.go 2.73% <0.00%> (+0.11%) ⬆️

📢 Thoughts on this report? Let us know!

Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: Shubham Gupta <[email protected]>
@shubham-cmyk shubham-cmyk merged commit 58db9ec into OT-CONTAINER-KIT:master Nov 10, 2023
18 of 19 checks passed
@shubham-cmyk shubham-cmyk deleted the secret branch November 10, 2023 23:47
mattrobinsonsre pushed a commit to mattrobinsonsre/redis-operator that referenced this pull request Jul 11, 2024
* fix client

Signed-off-by: Shubham Gupta <[email protected]>

* Add secret test

Signed-off-by: Shubham Gupta <[email protected]>

* fix lint

Signed-off-by: Shubham Gupta <[email protected]>

* update CI

Signed-off-by: Shubham Gupta <[email protected]>

* fix

Signed-off-by: Shubham Gupta <[email protected]>

---------

Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: Matt Robinson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant