Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] : support ignore specify annotation key in statefulset #666

Merged
merged 11 commits into from
Oct 10, 2023
Merged

[Feat] : support ignore specify annotation key in statefulset #666

merged 11 commits into from
Oct 10, 2023

Conversation

drivebyer
Copy link
Collaborator

Description

Fixes #555

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

@drivebyer drivebyer added the enhancement New feature or request label Oct 9, 2023
@drivebyer drivebyer requested a review from shubham-cmyk October 9, 2023 13:24
@shubham-cmyk
Copy link
Member

shubham-cmyk commented Oct 9, 2023 •
edited
Loading

@drivebyer Let's push another e2e to ensure the annotations are not present.
If you need help on that ping me.

Adding some e2e test with this PR is much needed

@shubham-cmyk
Copy link
Member

We could have

tests/e2e/v1beta2/ignore-annots/redis-cluster
&
tests/e2e/v1beta2/ignore-annots/redis-standalone

@drivebyer
Copy link
Collaborator Author

@drivebyer Let's push another e2e to ensure the annotations are not present.
If you need help on that ping me.

ok

@drivebyer
add e2e
146c6dd 
Signed-off-by: drivebyer <[email protected]>
@drivebyer
add test path
5d81d6c 
Signed-off-by: drivebyer <[email protected]>
@drivebyer
[DEBUG] ignore test dir
7b9b588 
Signed-off-by: drivebyer <[email protected]>
@drivebyer
remove comment
889ef82 
Signed-off-by: drivebyer <[email protected]>
@drivebyer
Copy link
Collaborator Author

ready to review @shubham-cmyk

@drivebyer
add test dirs
c6630e2 
Signed-off-by: drivebyer <[email protected]>
@drivebyer
remove exporter
5f07f5e 
Signed-off-by: drivebyer <[email protected]>
@shubham-cmyk
Copy link
Member

@drivebyer

We need to have a file annots-sts.yaml in redis cluster and redis-standalone.

Where we put that annots on the sts and put that file in the error or TestStep Like :
Refer : https://kuttl.dev/docs/testing/reference.html#teststep

error:
- my-errored-new-resource.yaml

Error make sure that it would fail

@drivebyer
Copy link
Collaborator Author

Error make sure that it would fail

ok, i would add it

@shubham-cmyk
Copy link
Member

@drivebyer
We should also add the
ready-pvc.yaml
&
ready-cluster.yaml

Make sure you have that annotation present in the ready-cluster.yaml.

In standalone we do the same but we won't have the status there because currently it was not added to that.

@drivebyer
add error assert
d3dc3fd 
Signed-off-by: drivebyer <[email protected]>
@drivebyer
add more assert
5c49b76 
Signed-off-by: drivebyer <[email protected]>
@shubham-cmyk
Copy link
Member

It would be ready to merge after these changes.

@drivebyer
add more assert
44c580e 
Signed-off-by: drivebyer <[email protected]>
shubham-cmyk
shubham-cmyk approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@shubham-cmyk shubham-cmyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shubham-cmyk shubham-cmyk merged commit f5c68da into OT-CONTAINER-KIT:master Oct 10, 2023
15 checks passed
@drivebyer drivebyer deleted the ignore-anno branch October 10, 2023 06:44
mattrobinsonsre pushed a commit to mattrobinsonsre/redis-operator that referenced this pull request Jul 11, 2024
@drivebyer @mattrobinsonsre
[Feat] : support ignore specify annotation key in statefulset (OT-CON…
52793d4 
…TAINER-KIT#666)

* Support ignore specify annotation key in statefulset

Signed-off-by: drivebyer <[email protected]>

* add e2e

Signed-off-by: drivebyer <[email protected]>

* add test path

Signed-off-by: drivebyer <[email protected]>

* [DEBUG] ignore test dir

Signed-off-by: drivebyer <[email protected]>

* remove comment

Signed-off-by: drivebyer <[email protected]>

* remove assert file, which already assert in setup directory

Signed-off-by: drivebyer <[email protected]>

* add test dirs

Signed-off-by: drivebyer <[email protected]>

* remove exporter

Signed-off-by: drivebyer <[email protected]>

* add error assert

Signed-off-by: drivebyer <[email protected]>

* add more assert

Signed-off-by: drivebyer <[email protected]>

* add more assert

Signed-off-by: drivebyer <[email protected]>

---------

Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubham-cmyk shubham-cmyk shubham-cmyk approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pod restarted when update annotation in custom resource
2 participants
@drivebyer @shubham-cmyk