Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: initContainer enabled properties not define in template #1152

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

drivebyer
Copy link
Collaborator

  • Bumped version and appVersion for redis, redis-cluster, redis-replication, and redis-sentinel charts to 0.16.4, 0.16.4, 0.16.6, and 0.16.8 respectively.
  • Enhanced initContainer properties in templates to include the 'enabled' field for better configuration management.

This update ensures consistency across the Redis charts and improves template rendering.

Description

Fixes #1147

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

- Bumped version and appVersion for redis, redis-cluster, redis-replication, and redis-sentinel charts to 0.16.4, 0.16.4, 0.16.6, and 0.16.8 respectively.
- Enhanced initContainer properties in templates to include the 'enabled' field for better configuration management.

This update ensures consistency across the Redis charts and improves template rendering.

Signed-off-by: drivebyer <[email protected]>
@drivebyer drivebyer added the bug Something isn't working label Dec 5, 2024
@drivebyer drivebyer merged commit a5dd80e into OT-CONTAINER-KIT:master Dec 5, 2024
7 checks passed
@drivebyer drivebyer deleted the chart branch December 5, 2024 08:19
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.09%. Comparing base (d121d86) to head (43b94d4).
Report is 142 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1152      +/-   ##
==========================================
- Coverage   35.20%   30.09%   -5.11%     
==========================================
  Files          19       54      +35     
  Lines        3213     6243    +3030     
==========================================
+ Hits         1131     1879     +748     
- Misses       2015     4174    +2159     
- Partials       67      190     +123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initcontainer is not working
1 participant