test: improve test

Signed-off-by: Shubham Gupta <[email protected]>
OT-CONTAINER-KIT · Apr 1, 2024 · 5e60431 · 5e60431
1 parent bc26ef6
commit 5e60431
Showing 1 changed file with 25 additions and 3 deletions.
diff --git a/k8sutils/finalizer_test.go b/k8sutils/finalizer_test.go
@@ -837,12 +837,34 @@ func TestAddFinalizer(t *testing.T) {
 		wantErr bool
 	}{
 		{
-			name: "Add finalizer",
+			name: "CR without finalizer",
 			args: args{
 				cr: &v1beta2.Redis{
 					ObjectMeta: metav1.ObjectMeta{
-						Name:      "test-redis",
-						Namespace: "default",
+						Name:       "test-redis",
+						Namespace:  "default",
+						Finalizers: []string{},
+					},
+				},
+				finalizer: RedisFinalizer,
+			},
+			want: &v1beta2.Redis{
+				ObjectMeta: metav1.ObjectMeta{
+					Name:       "test-redis",
+					Namespace:  "default",
+					Finalizers: []string{RedisFinalizer},
+				},
+			},
+			wantErr: false,
+		},
+		{
+			name: "CR with finalizer",
+			args: args{
+				cr: &v1beta2.Redis{
+					ObjectMeta: metav1.ObjectMeta{
+						Name:       "test-redis",
+						Namespace:  "default",
+						Finalizers: []string{RedisFinalizer},
 					},
 				},
 				finalizer: RedisFinalizer,