Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert prov 'combination' process_type back to 'conversion' #812

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

emiliom
Copy link
Collaborator

@emiliom emiliom commented Sep 16, 2022

A change I made in #806 had downstream ramifications that are best left to the next release, 0.6.4.

I am reverting the change the provenance process_type used in combine_echodata, from "combination" back to "conversion".

I'll self merge once the CI tests are complete.

See also discussions in #810 and #811

@emiliom emiliom self-assigned this Sep 16, 2022
@emiliom
Copy link
Collaborator Author

emiliom commented Sep 16, 2022

FYI it's possible that selective testing was applied in the CI, but I successfully ran the complete test suite locally.

@emiliom emiliom merged commit 07045b6 into OSOceanAcoustics:dev Sep 16, 2022
@emiliom emiliom deleted the revert_combination_prov branch December 24, 2022 03:07
@leewujung leewujung added this to the 0.6.4 milestone Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants