-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update a couple of "extra" EK60 Beam_group1 variables #1099
Update a couple of "extra" EK60 Beam_group1 variables #1099
Conversation
…and to remove redundancy
…d data_type to int types, and improve the attributes.
…tributes. Ensure int casting works as intended via encoding
|
Codecov Report
@@ Coverage Diff @@
## dev #1099 +/- ##
==========================================
- Coverage 78.12% 75.06% -3.07%
==========================================
Files 65 23 -42
Lines 6227 3393 -2834
==========================================
- Hits 4865 2547 -2318
+ Misses 1362 846 -516
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 53 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Thank you!
Great, thank you! |
Follows from #951 (comment), but for EK60. Complements PR #1094.
In
Beam_group1
:count
variableoffset
torange_sample_offset
range_sample_offset
todtype=int
,transmit_mode
todtype=np.byte
(analogous tochannel_mode
in EK80) anddata_type
todtype=np.byte
.range_sample_offset
,transmit_mode
, anddata_type
; partly for consistency with EK80NOTES:
The casting to integer types is currently not working! The EchoData DataArrays end up being float types. I'm looking into it.transmit_mode
seems to be identical tochannel_mode
in EK80. @leewujung can you confirm? If they are, let's use the same variable name (channel_mode
? Or change EK80 totransmit_mode
?) and attribute values.