Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework MVBS tests #756

Closed
leewujung opened this issue Jul 7, 2022 · 1 comment
Closed

Rework MVBS tests #756

leewujung opened this issue Jul 7, 2022 · 1 comment
Assignees
Labels
Milestone

Comments

@leewujung
Copy link
Member

Right now our tests for compute_MVBS are pretty messy and we can benefit from reworking this for robustness and readability.

A laundry list of the few things I noticed while working on #753 were:

  • operations in _construct_MVBS_toy_data and _construct_MVBS_test_data either are hard to decipher or seem can be simplified. It may be the best to rewrite these.
  • factor out common components between test_compute_MVBS_index_binning and test_compute_MVBS to reduce redundancy and avoid error
  • the above work with constructed data
  • test_preprocess_mvbs runs through the mechanism for real data, we should keep this but consider adding variations of the target echo_range and ping_time binning intervals
  • add test for Sv data with different length along the range_sample dimension for different channel
  • use np.equal instead of np.allclose when testing computed values
  • use pytest parameterization to reduce clutter and redundancy
  • separate out MVBS-related tests to a separate .py file
@leewujung leewujung added this to the 0.6.2 milestone Jul 7, 2022
@leewujung leewujung moved this to Todo in Echopype Jul 7, 2022
@leewujung leewujung modified the milestones: 0.6.2, 0.6.3 Jul 28, 2022
@leewujung leewujung modified the milestones: 0.6.3, 0.6.4 Oct 13, 2022
@leewujung leewujung modified the milestones: 0.6.4, 0.7.0 Dec 1, 2022
@leewujung leewujung modified the milestones: 0.7.0, 0.7.1 Mar 9, 2023
@leewujung leewujung modified the milestones: 0.7.1, 0.7.2, 0.7.3 May 17, 2023
@leewujung leewujung modified the milestones: 0.8.2, 0.8.1 Aug 21, 2023
@lsetiawan
Copy link
Member

This may be addressed in #1124

@github-project-automation github-project-automation bot moved this from Todo to Done in Echopype Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants