Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core 2D binning routine for multiple functions #1028

Closed
leewujung opened this issue Apr 11, 2023 · 0 comments
Closed

Core 2D binning routine for multiple functions #1028

leewujung opened this issue Apr 11, 2023 · 0 comments

Comments

@leewujung
Copy link
Member

leewujung commented Apr 11, 2023

A few functions require the same binning routine along ping_time and depth or along distance and depth: compute_MVBS, compute_NASC, estimate_noise. This is a simple operation if this binning is based on indices (e.g., 0, 1, 2, ...), but becomes non-trivial if the binning is based on the labels (e.g., the actual ping_time which are not integers). This is because in the latter case checking the actual values in the labels is required to determine which bin a data point should fall in.

The label spacing along the depth dimension is typically the same when the data is calibrated using a single sound speed value, since the sample_interval is constant within a single ping. However, a case that sometimes occurs is when the sample_interval switches to another value after a certain number of pings. This is especially likely to occur if we combine EchoData from multiple files. Doing binned averages for such as case was added in #878, but there continues to be efficiency/memory issue related to the implementation.

This issue is for working on a core 2D binning routine to enhance efficiency, memory usage, and robustness against different types of data.

Related issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants