Enable using location search with shorter place names #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nominatim does not return prefix matches, so it could be good to even remove this minimum limit. However, searches with only a single Latin letter can take more than 1 second on Nominatim's end. So, perhaps it's good to first relax the global limit to 2 characters and have additional logic that there is no minimum limit if the input text contains characters from certain scripts.
Make the minimum limit depend on the input characters. No limit is used if the input contains characters that are used in the following CJK scripts: Han, Hangul, Hiragana and Katakana. These scripts were chosen because there are place names that can be written with 1 character in Han, Hiragana and Katakana. In Hangul, it looks possible that such place names exist and often an input method similar to the other scripts is used, which reduces the probability of triggering search with only 1 character when the user has not yet finished typing. New scripts can be added to the regular expression with a similar reasoning. `scx` is used in the regular expression because `Script_Extensions` is a more useful property than `Script` when a single Unicode character can be used in multiple scripts. It would be even simpler to just remove the limit completely because Nominatim does not return prefix matches. However, at least queries that contain only 1 Latin letter take longer than queries with at least a few characters. Also, the component that displays the results seems to have some kind of problem displaying the results for the subsequent queries and this problem might become more apparent for more users if the character limit is removed.
lliehu
force-pushed
the
fix-chinese-input
branch
from
0faf9a1
to
13a4e4f
Compare
|
@willemarcel Could I request your review on this? GitHub doesn't allow me to add any reviewers to this PR. I hope you forgive this ping after weeks of waiting and not understanding how to better request a review from someone in this project. |
|
@lliehu sorry for the delay and thanks for the PR. I'll review it this week. |
jake-low
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first attempt at fixing problems with location search when Chinese or other similar languages are used. Please see commit messages for details.
Related issue is: #538
Tested manually on both Firefox and Brave. It looks like the used select component has more strange issues. Was not able to fix those but also checked that I didn't create more issues. The react-select version is quite old:
^1.0.0-rc.5inpackage.jsonwhile latest release is 5.7.3.