-
Notifications
You must be signed in to change notification settings - Fork 1
Updates necessary for the Heroku deployment #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Andrew Berezovskyi <[email protected]>
Signed-off-by: Andrew Berezovskyi <[email protected]>
Signed-off-by: Andrew Berezovskyi <[email protected]>
Signed-off-by: Andrew Berezovskyi <[email protected]>
Signed-off-by: Andrew Berezovskyi <[email protected]>
Signed-off-by: Andrew Berezovskyi <[email protected]>
Signed-off-by: Andrew Berezovskyi <[email protected]>
Signed-off-by: Andrew Berezovskyi <[email protected]>
Signed-off-by: Andrew Berezovskyi <[email protected]>
Signed-off-by: Andrew Berezovskyi <[email protected]>
Signed-off-by: Andrew Berezovskyi <[email protected]>
Signed-off-by: Andrew Berezovskyi <[email protected]>
Signed-off-by: Andrew Berezovskyi <[email protected]>
Signed-off-by: Andrew Berezovskyi <[email protected]>
Signed-off-by: Andrew Berezovskyi <[email protected]>
Signed-off-by: Andrew Berezovskyi <[email protected]>
Signed-off-by: Andrew Berezovskyi <[email protected]>
Signed-off-by: Andrew Berezovskyi <[email protected]>
Signed-off-by: Andrew Berezovskyi <[email protected]>
Signed-off-by: Andrew Berezovskyi <[email protected]>
Signed-off-by: Andrew Berezovskyi <[email protected]>
Signed-off-by: Andrew Berezovskyi <[email protected]>
Signed-off-by: Andrew Berezovskyi <[email protected]>
Signed-off-by: Andrew Berezovskyi <[email protected]>
Signed-off-by: Andrew Berezovskyi <[email protected]>
Signed-off-by: Andrew Berezovskyi <[email protected]>
POST is now fixed but GET returns an empty response |
@@ -1,7 +1,8 @@ | |||
{ | |||
"scheme": "http", | |||
"host": "localhost", | |||
"protocol": "http", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scheme and host are the w3c names used in https://www.w3.org/Addressing/URL/url-spec.txt. These should be named using standard terms in the config.json file to avoid confusion. scheme is the name of the protocol to use, host is the name of the node to bind to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made this change so that the JSON keys match the attributes in the https://nodejs.org/docs/latest-v10.x/api/url.html
@@ -67,13 +67,13 @@ function ensureIndex() { | |||
} | |||
|
|||
exports.init = function(env, callback) { | |||
require('mongodb').connect(env.mongoURL, function(err, conn) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have:
const MongoClient = require('mongodb').MongoClient;
const client = new MongoClient(env.mongoURL, { useNewUrlParser: true });
client.connect(function(err, client) {
if (err) {
callback(err);
return;
}
db = client.db(env.dbName);
exports.graphs = graphs();
console.log("Connected to MongoDB at: "+env.mongoURL);
ensureIndex();
Here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
n3 1.1.1 is the latest and requires significant changes in the Mongo db. Not sure this is worth doing in this sample app. ldp-service uses rdflib instead. Perhaps we should leave LDPjs alone and do new development in ldp-app, ldp-services.
Thanks Jim. Very likely I will abandon this patch. Let me try the ldp-app first. |
Note viz.js doesn't yet work on ldp-app because it had a hard dependency on the MongoDB representations of triples. |
https://ldpjs-refimpl.herokuapp.com/