Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/vector/Vlib: Fix Resource Leak issue in open_ogr.c #4960

Merged
merged 5 commits into from
Feb 4, 2025

Conversation

ShubhamDesai
Copy link
Contributor

This pull request fixes issue identified by Coverity Scan (CID : 1588911)
Used fclose() to fix this issue

@github-actions github-actions bot added vector Related to vector data processing C Related code is in C libraries labels Jan 16, 2025
@nilason
Copy link
Contributor

nilason commented Jan 16, 2025

Please address CID 1207813 and 1207814 here too.

Shubham Vasudeo Desai added 2 commits January 22, 2025 12:44
@ShubhamDesai
Copy link
Contributor Author

Please address CID 1207813 and 1207814 here too.

Done addressed.

Copy link
Contributor

@nilason nilason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just some minor suggestions.

lib/vector/Vlib/open_ogr.c Outdated Show resolved Hide resolved
lib/vector/Vlib/open_ogr.c Show resolved Hide resolved
lib/vector/Vlib/open_ogr.c Show resolved Hide resolved
@nilason nilason added this to the 8.5.0 milestone Jan 31, 2025
@nilason nilason merged commit 805aba1 into OSGeo:main Feb 4, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Related code is in C libraries vector Related to vector data processing
Projects
Development

Successfully merging this pull request may close these issues.

2 participants