Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

g.extension: fix getting addon directories names without Py/C source code #4900

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix typos
tmszi committed Jan 3, 2025
commit 92019bcf335c0eb4c6f9cc776524584e4c9cc09c
6 changes: 3 additions & 3 deletions scripts/g.extension/g.extension.py
Original file line number Diff line number Diff line change
@@ -1447,7 +1447,7 @@ def install_extension_xml(edict):


def get_multi_addon_addons_which_install_only_html_man_page():
"""Get multi-addon addons which install only manual html page
"""Get multi-addon addons which installs only manual HTML page

:return list addon_dirs: list of addon directories which does
not contain any Python or C source code
@@ -1475,7 +1475,7 @@ def get_multi_addon_addons_which_install_only_html_man_page():
addon_paths.index(addon_src_file.group(0).replace("\n", ""))
)
gs.debug(
f"Addon dicrectory names <{', '.join(addon_dirs)}> which "
f"Addon directory names <{', '.join(addon_dirs)}> which "
" does not contain any Python or C source code files."
)
return addon_dirs
@@ -2432,7 +2432,7 @@ def update_manual_page(module):
# Multi-addon
if len(addons) > 1:
for a in get_multi_addon_addons_which_install_only_html_man_page():
# Add multi-addon addons which install only manual html page
# Add multi-addon addons which installs only manual HTML page
addons.append(a)

for match in re.finditer(pattern, shtml):
2 changes: 1 addition & 1 deletion scripts/g.extension/testsuite/test_addons_download.py
Original file line number Diff line number Diff line change
@@ -237,7 +237,7 @@ def test_github_install_official_multimodule_and_check_metadata(self):
gextension.outputs.stderr,
)
self.assertIn(
f"Addon name <{extension}> which install only HTML man page.",
f"Addon name <{extension}> which installs only HTML man page.",
gextension.outputs.stderr,
)