Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Fix C0117: Consider changing "not self.optype == 'boolean'" to "self.optype != 'boolean'" (unnecessary-negation) #4895

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

echoix
Copy link
Member

@echoix echoix commented Dec 27, 2024

@github-actions github-actions bot added GUI wxGUI related Python Related code is in Python libraries labels Dec 27, 2024
Copy link
Member

@ninsbl ninsbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was an easy one to review...

@echoix echoix merged commit f7efef2 into OSGeo:main Dec 27, 2024
26 checks passed
@echoix echoix deleted the fix-pylint-C0117-unnecessary-negation branch December 27, 2024 23:10
@github-actions github-actions bot added this to the 8.5.0 milestone Dec 27, 2024
@echoix
Copy link
Member Author

echoix commented Dec 27, 2024

That was an easy one to review...

Haha yes indeed

@echoix
Copy link
Member Author

echoix commented Dec 27, 2024

That was an easy one to review...

I started from the bottom, with less occurrences first, so it will be increasingly bigger and harder PRs

echoix added a commit to echoix/grass that referenced this pull request Dec 31, 2024
… "self.optype != 'boolean'" (unnecessary-negation) (OSGeo#4895)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI wxGUI related libraries Python Related code is in Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants