d.vect: Dereference after Null Check #4640
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShubhamDesai
changed the title
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
nilason
requested changes
Nov 28, 2024
display/d.vect/lines.c
Outdated
Comment on lines
348
to
349
| else { | ||
| G_warning(_("Symbol is NULL; unable to display points")); |
There was a problem hiding this comment.
No need for this else statement (with warning). The only situation Symb is NULL is if the call Symb = S_read(symbol_name); in line 325 fails (in which case a warning is issued anyway).
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Done. |
|
@ShubhamDesai When you'll have the chance, could you take a look at why there's multiple test failures across OSes? |
yes |
|
I still don't see where the -6 error comes from.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes issue identified by Coverity scan (CID : 1207395)
Changes Made: