style: Fix if-else-block-instead-of-if-exp (SIM108) (part 3) #4570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/temporal/gui_support.py
…ive() in grass.temporal.AbstractDataset
github-actions
bot
added
GUI
|
On my fork I think it's bandit that will complain about the use of eval, that is only moved around |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| "" if keywords is None or keywords.text is None else keywords.text | ||
| ) | ||
| shortcut = shortcut.text if shortcut is not None else "" | ||
| wxId = eval("wx." + wxId.text) if wxId is not None else wx.ID_ANY |
Check warning
Code scanning / Bandit
Use of possibly insecure function - consider using safer ast.literal_eval. Warning
petrasovaa
reviewed
Oct 24, 2024
petrasovaa
reviewed
Oct 24, 2024
petrasovaa
reviewed
Oct 24, 2024
petrasovaa
reviewed
Oct 24, 2024
Co-authored-by: Anna Petrasova <[email protected]>
| "" if keywords is None or keywords.text is None else keywords.text | ||
| ) | ||
| shortcut = shortcut.text if shortcut is not None else "" | ||
| wxId = eval("wx." + wxId.text) if wxId is not None else wx.ID_ANY |
Check warning
Code scanning / Bandit
Use of possibly insecure function - consider using safer ast.literal_eval.
petrasovaa
reviewed
Oct 25, 2024
petrasovaa
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last PR of this series. It finishes by enabling checking the rule with ruff.
PRs in this series: #4562, #4561
Ruff rule: https://docs.astral.sh/ruff/rules/if-else-block-instead-of-if-exp