lib/db: remove deprecated implementation of db_get_login() and replace it with that of db_get_login2() #4302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
vector
ymdatta
changed the title
nilason
changed the title
|
I think this (8.5) may the moment to drop it. |
|
(The CodeQL CI failure is unrelated to changes of this PR.) |
ymdatta
added a commit
to ymdatta/grass
that referenced
this pull request
Sep 12, 2024
In a similar vein to OSGeo#4302, remove deprecated implementation of db_set_login() and replace it with that of db_set_login2(). Along with db_get_login(), db_set_login() was deprecated (in favour of db_set_login2) in 2015 with the 7.8.0 release. Commit: da399c5 Signed-off-by: Mohan Yelugoti <[email protected]>
wenzeslaus
reviewed
Sep 12, 2024
ymdatta
changed the title
ymdatta
force-pushed
the
dbgetlogin_refactor
branch
from
b958c86
to
1ee9a80
Compare
db_get_login() is deprecated in 7.8.0 release with da399c5. Change its function signature and implementation to match that of the currently preferred db_get_login2(). Modify db_get_login2() to internally call db_get_login() function call. In the future major version, db_get_login2() would be removed to have only one method to get login details for simplicity. Signed-off-by: Mohan Yelugoti <[email protected]>
ymdatta
force-pushed
the
dbgetlogin_refactor
branch
from
1ee9a80
to
53285d2
Compare
wenzeslaus
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
db_get_login()is deprecated in 7.8.0 release with da399c5. Change its function signature and implementation to match that of the currently preferreddb_get_login2().Modify
db_get_login2()to internally calldb_get_login()function call. In the future major version,db_get_login2()would be removed to have only one method to get login details for simplicity.