v.to.rast: Add points without segfault with densification flag (-d) #3440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuidaeCho
force-pushed
the
v_to_rast_no_densification_for_point_type
branch
from
01b0516 to
d868f5c
Compare
HuidaeCho
added
bug
echoix
reviewed
Mar 11, 2024
Comment on lines
+278
to
+280
| /* point plotting, alternative to G_plot_point() | ||
| * x, y are col, row numbers */ | ||
| void plot_point(double east, double north) |
There was a problem hiding this comment.
If it is an alternative, does that mean that if changes to the G_plot_point() are made, they may need to be kept in sync/compatible with the function here? If so, should we add a note in the comments of G_plot_point() to refer back here (to not forget in the future)?
petrasovaa
reviewed
May 9, 2024
Comment on lines
+284
to
+285
| x = ifloor(X(G_adjust_easting(east, &st->window)) + 0.5); | ||
| y = ifloor(Y(north) + 0.5); |
There was a problem hiding this comment.
Any reason why not to use G_plot_where_xy here?
There was a problem hiding this comment.
st in G_plot_where_xy() is static and internal to libgis. dense_line.c has its own st.
neteler
added
the
backport to 8.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #3105. It implements a new
plot_point()function that uses the internalstateindense_line.c. CallingG_plot_point()with-dflag causes a segfault because the staticstateinlibgisis not shared with any modules.