Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Allow periodic update workflow to create a branch #4147

Open
echoix opened this issue Aug 7, 2024 · 2 comments
Open

[Bug] Allow periodic update workflow to create a branch #4147

echoix opened this issue Aug 7, 2024 · 2 comments
Assignees
Labels
bug Something isn't working CI Continuous integration

Comments

@echoix
Copy link
Member

echoix commented Aug 7, 2024

Describe the bug

The periodic update workflow, that runs each month, failed today to create a pull request because of branch naming rules' conventions.

To reproduce

  1. See https://github.com/OSGeo/grass/actions/runs/10282750517/job/28455092371

Expected behavior

Relax naming rule conventions to allow the specified branch (by GitHub actions or the person with the PAT used for it).

At the same time, it would be nice to also allow branches starting with revert- followed by a series of numbers corresponding to the PR's number, then followed by another dash. This is what the GitHub interface generates when using the "revert" feature on a merged PR. It is currently unusable for now.

Screenshots

System description

Main at ref 1527322

@echoix echoix added bug Something isn't working CI Continuous integration labels Aug 7, 2024
@nilason
Copy link
Contributor

nilason commented Aug 15, 2024

See related #3308. There are alternatives to be explored.

@echoix
Copy link
Member Author

echoix commented Aug 15, 2024

In either way, we still have some branch name patterns to allow in the repos settings, as we were too strict in June when changing these settings (as we weren't strict enough the last iteration and had unexpected situations where branches were made in the repo out of a fork)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI Continuous integration
Projects
None yet
Development

No branches or pull requests

3 participants