v.surf.nnbathy: Fix exception type for Python 3 #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes both v.surf.nnbathy and r.surf.nnbathy because r.surf.nnbathy imports the Python module installed with v.surf.nnbathy. Fixes Pylint error E0602: Undefined variable 'StandardError' (undefined-variable), but introduces warning W0718: Catching too general exception Exception (broad-exception-caught). This is aiming at making the tool run with Python 3 and GRASS GIS 8. Proper fix would separate try-except blocks to the relevant parts. Now two string splits, all vector handling and file writing are all in one try-except which catches everything including IndexError and AttributeError. This basic fix is just applying The Conservative Python 3 Porting Guide without further changes.
petrasovaa
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes both v.surf.nnbathy and r.surf.nnbathy because r.surf.nnbathy imports the Python module installed with v.surf.nnbathy.
Fixes Pylint error E0602: Undefined variable 'StandardError' (undefined-variable), but introduces warning W0718: Catching too general exception Exception (broad-exception-caught).
This is aiming at making the tool run with Python 3 and GRASS GIS 8. Proper fix would separate try-except blocks to the relevant parts. Now two string splits, all vector handling and file writing are all in one try-except which catches everything including IndexError and AttributeError. This basic fix is just applying The Conservative Python 3 Porting Guide without further changes.