i.sam2: SamGeo2 model #1244

cwhite911 · 2024-11-16T03:21:30Z

A new module i.sam2 for segmenting orthoimagery using text prompts with the SAMGeo model (Segment Anything Model Geospatial).

i.sam2 group=rgb_255 output=tree_mask text_prompt="trees"

ecodiv · 2024-11-16T06:37:39Z

Cool, need to try this out.

src/imagery/i.sam2/i.sam2.py

Co-authored-by: Markus Neteler <[email protected]>

cwhite911 · 2024-11-18T01:00:30Z

I've submitted PR: opengeos/segment-geospatial#370 to fix an upstream issue in the segment-geospatial library.

neteler · 2024-11-18T10:08:01Z

Would you mind to add "trees.png" in a higher resolution (perhaps as JPG), at time it is only 640 x 480.

The code for a clickable image figure is found at
https://github.com/OSGeo/grass/blob/main/doc/development/style_guide.md#documentation
-> code it at the end of this section

Please also change the name to i_sam2_trees.jpg. Thanks!

veroandreo · 2024-11-18T22:33:33Z

So cool, @cwhite911! Would you mind adding the requirements and how to install it within the manual page as in here, for example. It would be more visible for users and clear, too.

src/imagery/i.sam2/i.sam2.py

ecodiv · 2024-12-03T10:59:36Z

I tried to run this on Windows 10, GRAS GIS 8.4, installed via OSGeo4W. I am getting the following errors:

ERROR: Could not install packages due to an OSError:
[WinError 5] Access is denied:
'C:\\OSGeo4W\\apps\\Python312\\Lib\\site-
packages\\cv2\\cv2.pyd'
Consider using the `--user` option or check the permissions.
Installing GroundingDINO...
Collecting groundingdino-py
Using cached groundingdino_py-0.4.0-py2.py3-none-any.whl
Requirement already satisfied: torch in c:\osgeo4w\apps\python312\lib\site-packages (from groundingdino-py) (2.5.1)
Requirement already satisfied: torchvision in c:\osgeo4w\apps\python312\lib\site-packages (from groundingdino-py) (0.20.1)
Collecting transformers (from groundingdino-py)
Using cached transformers-4.46.3-py3-none-any.whl.metadata (44 kB)
Requirement already satisfied: addict in c:\osgeo4w\apps\python312\lib\site-packages (from groundingdino-py) (2.4.0)
Requirement already satisfied: yapf in c:\osgeo4w\apps\python312\lib\site-packages (from groundingdino-py) (0.43.0)
Requirement already satisfied: timm in c:\osgeo4w\apps\python312\lib\site-packages (from groundingdino-py) (1.0.11)
Requirement already satisfied: numpy in c:\osgeo4w\apps\python312\lib\site-packages (from groundingdino-py) (1.26.4)
Collecting opencv-python (from groundingdino-py)
Using cached opencv_python-4.10.0.84-cp37-abi3-win_amd64.whl.metadata (20 kB)
Collecting supervision==0.6.0 (from groundingdino-py)
Using cached supervision-0.6.0-py3-none-any.whl.metadata (6.2 kB)
Requirement already satisfied: pycocotools in c:\osgeo4w\apps\python312\lib\site-packages (from groundingdino-py) (2.0.8)
Requirement already satisfied: matplotlib in c:\osgeo4w\apps\python312\lib\site-packages (from supervision==0.6.0->groundingdino-py) (3.8.4)
Requirement already satisfied: pyyaml in c:\osgeo4w\apps\python312\lib\site-packages (from timm->groundingdino-py) (6.0.1)
Requirement already satisfied: huggingface_hub in c:\osgeo4w\apps\python312\lib\site-packages (from timm->groundingdino-py) (0.26.3)
Requirement already satisfied: safetensors in c:\osgeo4w\apps\python312\lib\site-packages (from timm->groundingdino-py) (0.4.5)
Requirement already satisfied: filelock in c:\osgeo4w\apps\python312\lib\site-packages (from torch->groundingdino-py) (3.16.1)
Requirement already satisfied: typing-extensions>=4.8.0 in c:\osgeo4w\apps\python312\lib\site-packages (from torch->groundingdino-py) (4.12.2)
Requirement already satisfied: networkx in c:\osgeo4w\apps\python312\lib\site-packages (from torch->groundingdino-py) (3.4.2)
Requirement already satisfied: jinja2 in c:\osgeo4w\apps\python312\lib\site-packages (from torch->groundingdino-py) (3.1.3)
Requirement already satisfied: fsspec in c:\osgeo4w\apps\python312\lib\site-packages (from torch->groundingdino-py) (2024.10.0)
Requirement already satisfied: setuptools in c:\osgeo4w\apps\python312\lib\site-packages (from torch->groundingdino-py) (69.2.0)
Requirement already satisfied: sympy==1.13.1 in c:\osgeo4w\apps\python312\lib\site-packages (from torch->groundingdino-py) (1.13.1)
Requirement already satisfied: mpmath<1.4,>=1.1.0 in c:\osgeo4w\apps\python312\lib\site-packages (from sympy==1.13.1->torch->groundingdino-py) (1.3.0)
Requirement already satisfied: pillow!=8.3.*,>=5.3.0 in c:\osgeo4w\apps\python312\lib\site-packages (from torchvision->groundingdino-py) (11.0.0)
Requirement already satisfied: packaging>=20.0 in c:\osgeo4w\apps\python312\lib\site-packages (from transformers->groundingdino-py) (24.0)
Requirement already satisfied: regex!=2019.12.17 in c:\osgeo4w\apps\python312\lib\site-packages (from transformers->groundingdino-py) (2024.11.6)
Requirement already satisfied: requests in c:\osgeo4w\apps\python312\lib\site-packages (from transformers->groundingdino-py) (2.31.0)
Collecting tokenizers<0.21,>=0.20 (from transformers->groundingdino-py)
Using cached tokenizers-0.20.3-cp312-none-win_amd64.whl.metadata (6.9 kB)
Requirement already satisfied: tqdm>=4.27 in c:\osgeo4w\apps\python312\lib\site-packages (from transformers->groundingdino-py) (4.67.1)
Requirement already satisfied: platformdirs>=3.5.1 in c:\osgeo4w\apps\python312\lib\site-packages (from yapf->groundingdino-py) (4.3.6)
Requirement already satisfied: contourpy>=1.0.1 in c:\osgeo4w\apps\python312\lib\site-packages (from matplotlib->supervision==0.6.0->groundingdino-py) (1.2.1)
Requirement already satisfied: cycler>=0.10 in c:\osgeo4w\apps\python312\lib\site-packages (from matplotlib->supervision==0.6.0->groundingdino-py) (0.12.1)
Requirement already satisfied: fonttools>=4.22.0 in c:\osgeo4w\apps\python312\lib\site-packages (from matplotlib->supervision==0.6.0->groundingdino-py) (4.51.0)
Requirement already satisfied: kiwisolver>=1.3.1 in c:\osgeo4w\apps\python312\lib\site-packages (from matplotlib->supervision==0.6.0->groundingdino-py) (1.4.5)
Requirement already satisfied: pyparsing>=2.3.1 in c:\osgeo4w\apps\python312\lib\site-packages (from matplotlib->supervision==0.6.0->groundingdino-py) (3.1.2)
Requirement already satisfied: python-dateutil>=2.7 in c:\osgeo4w\apps\python312\lib\site-packages (from matplotlib->supervision==0.6.0->groundingdino-py) (2.9.0.post0)
Requirement already satisfied: colorama in c:\osgeo4w\apps\python312\lib\site-packages (from tqdm>=4.27->transformers->groundingdino-py) (0.4.6)
Requirement already satisfied: MarkupSafe>=2.0 in c:\osgeo4w\apps\python312\lib\site-packages (from jinja2->torch->groundingdino-py) (2.1.5)
Requirement already satisfied: charset-normalizer<4,>=2 in c:\osgeo4w\apps\python312\lib\site-packages (from requests->transformers->groundingdino-py) (3.3.2)
Requirement already satisfied: idna<4,>=2.5 in c:\osgeo4w\apps\python312\lib\site-packages (from requests->transformers->groundingdino-py) (3.7)
Requirement already satisfied: urllib3<3,>=1.21.1 in c:\osgeo4w\apps\python312\lib\site-packages (from requests->transformers->groundingdino-py) (2.2.1)
Requirement already satisfied: certifi>=2017.4.17 in c:\osgeo4w\apps\python312\lib\site-packages (from requests->transformers->groundingdino-py) (2024.2.2)
Requirement already satisfied: six>=1.5 in c:\osgeo4w\apps\python312\lib\site-packages (from python-dateutil>=2.7->matplotlib->supervision==0.6.0->groundingdino-py) (1.16.0)
Using cached supervision-0.6.0-py3-none-any.whl (31 kB)
Using cached opencv_python-4.10.0.84-cp37-abi3-win_amd64.whl (38.8 MB)
Using cached transformers-4.46.3-py3-none-any.whl (10.0 MB)
Using cached tokenizers-0.20.3-cp312-none-win_amd64.whl (2.4 MB)
Installing collected packages: opencv-python, tokenizers, supervision, transformers, groundingdino-py
Please restart the kernel and run the notebook again.
Group <landsat_test> references the following raster maps:
WARNING: Illegal filename <landsat
>. Character <
> not allowed.
ERROR: Raster map <lsat5_1987_10@landsat
> not found
Traceback (most recent call last):
  File "C:\Users\brp\AppData\Roaming\GRASS8\addons/scripts\i
.sam2.py", line 187, in <module>
    sys.exit(main())
             ^^^^^^
  File "C:\Users\brp\AppData\Roaming\GRASS8\addons/scripts\i
.sam2.py", line 106, in main
    input_image_np = list([garray.array(raster,
dtype=np.uint8) for raster in rasters])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\OSGeo4W\apps\grass\grass84\etc\python\grass\scrip
t\array.py", line 161, in __new__
    gcore.run_command(
  File "C:\OSGeo4W\apps\grass\grass84\etc\python\grass\scrip
t\core.py", line 487, in run_command
    return handle_errors(returncode, result=None, args=args,
kwargs=kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
^^^^^^^^^^^^^^^
  File "C:\OSGeo4W\apps\grass\grass84\etc\python\grass\scrip
t\core.py", line 366, in handle_errors
    raise CalledModuleError(module=module, code=code,
returncode=returncode)
grass.exceptions.CalledModuleError: Module run `r.out.bin
--o --q -i input=lsat5_1987_10@landsat
 output=D:\GRASStest\nc_spm_08_grass7\landsat\.tmp/unknown\1
5608.1 bytes=1` ended with an error.
The subprocess ended with a non-zero return code: 1. See
errors above the traceback or in the error output.

src/imagery/i.sam2/i.sam2.py

ecodiv

@cwhite911 Please see feedback in code

cwhite911 · 2024-12-23T17:25:38Z

So cool, @cwhite911! Would you mind adding the requirements and how to install it within the manual page as in here, for example. It would be more visible for users and clear, too.

@veroandreo I've just updated the docs with the full list of dependencies in the requirements section.

veroandreo

minor typos fixed

src/imagery/i.sam2/i.sam2.html

src/imagery/i.sam2/i.sam2.py

Co-authored-by: Veronica Andreo <[email protected]>

veroandreo

Only minor things :)

veroandreo · 2025-01-31T21:44:37Z

src/imagery/i.sam2/i.sam2.py


+def normalize_rgb_array(rgb_array):
+    """
+    Normalize an RGB array to the range [0, 255].


Suggested change

Normalize an RGB array to the range [0, 255].

Normalizes an RGB array to the range [0, 255].

veroandreo · 2025-01-31T21:45:04Z

src/imagery/i.sam2/i.sam2.py

-        torch.cuda.empty_cache()
+def run_samgeo_segmentation(temp_input_path, temp_output_path, model_path, device):
+    """
+    Run SAMGeo segmentation on an input image and save the output.


Suggested change

Run SAMGeo segmentation on an input image and save the output.

Runs SAMGeo segmentation on an input image and saves the output.

veroandreo · 2025-01-31T21:47:45Z

src/imagery/i.sam2/i.sam2.py

+    input_np_array (list of numpy.ndarray): A list of numpy arrays representing the input raster bands.
+    output_raster (str): The name of the output raster map to be created in GRASS GIS.
+
+    Raises:
+    ValueError: If the input array is empty or if the masks do not have the same shape.
+
+    This function merges multiple raster bands into a single raster, where each band is assigned a unique value.
+    The merged raster is then written to a GRASS GIS raster map.


This is the first time you use raster "bands". Would it be equivalent to use raster maps or segmented masks?

Corey White added 2 commits November 15, 2024 22:06

i.sam2: SamGeo2 model

9e084de

Updated docs

8f35e5d

neteler reviewed Nov 16, 2024

View reviewed changes

src/imagery/i.sam2/i.sam2.py Outdated Show resolved Hide resolved

neteler reviewed Nov 16, 2024

View reviewed changes

src/imagery/i.sam2/i.sam2.py Outdated Show resolved Hide resolved

cwhite911 and others added 3 commits November 16, 2024 12:02

Update i.sam2.py keywords

1706d70

Co-authored-by: Markus Neteler <[email protected]>

Update i.sam2.py: updated description

462be0e

Co-authored-by: Markus Neteler <[email protected]>

Merge branch 'grass8' into i.sam2

caee33a

cwhite911 mentioned this pull request Nov 18, 2024

text_sam: Fixed issue when passing PIL Image as input to SamGeo2 opengeos/segment-geospatial#370

Merged

Code clean up, improved docs

0fb59f2

Updated image size

b769ba2

ecodiv reviewed Dec 3, 2024

View reviewed changes

src/imagery/i.sam2/i.sam2.py Outdated Show resolved Hide resolved

ecodiv reviewed Dec 3, 2024

View reviewed changes

src/imagery/i.sam2/i.sam2.py Outdated Show resolved Hide resolved

ecodiv requested changes Dec 13, 2024

View reviewed changes

cwhite911 and others added 2 commits December 23, 2024 08:57

Merge branch 'grass8' into i.sam2

df35729

Updated install docs

fdee2cb

Updated imagery group raster parsing for windows

3556f1a

veroandreo reviewed Dec 24, 2024

View reviewed changes

src/imagery/i.sam2/i.sam2.html Outdated Show resolved Hide resolved

src/imagery/i.sam2/i.sam2.py Outdated Show resolved Hide resolved

cwhite911 and others added 2 commits December 24, 2024 06:11

Update i.sam2.py

2b77fed

Co-authored-by: Veronica Andreo <[email protected]>

Update i.sam2.html

29687c4

Co-authored-by: Veronica Andreo <[email protected]>

ecodiv approved these changes Dec 27, 2024

View reviewed changes

Merge branch 'grass8' into i.sam2

6f25e2f

cwhite911 added new addon PR contains a new addon or issue proposes one Python Related code is in Python labels Jan 17, 2025

Merge branch 'grass8' into i.sam2

3e349b4

Merge branch 'grass8' into i.sam2

ce405aa

cwhite911 requested review from neteler and veroandreo January 22, 2025 16:39

cwhite911 and others added 2 commits January 27, 2025 09:22

Merge branch 'grass8' into i.sam2

ed18ab7

Refactored into smaller functions

94dd709

veroandreo approved these changes Jan 31, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

i.sam2: SamGeo2 model #1244

i.sam2: SamGeo2 model #1244

cwhite911 commented Nov 16, 2024

ecodiv commented Nov 16, 2024

cwhite911 commented Nov 18, 2024

neteler commented Nov 18, 2024

veroandreo commented Nov 18, 2024

ecodiv commented Dec 3, 2024

ecodiv left a comment

cwhite911 commented Dec 23, 2024

veroandreo left a comment

veroandreo left a comment

veroandreo Jan 31, 2025

veroandreo Jan 31, 2025

veroandreo Jan 31, 2025

	Normalize an RGB array to the range [0, 255].
	Normalizes an RGB array to the range [0, 255].

	Run SAMGeo segmentation on an input image and save the output.
	Runs SAMGeo segmentation on an input image and saves the output.

i.sam2: SamGeo2 model #1244

Are you sure you want to change the base?

i.sam2: SamGeo2 model #1244

Conversation

cwhite911 commented Nov 16, 2024

ecodiv commented Nov 16, 2024

cwhite911 commented Nov 18, 2024

neteler commented Nov 18, 2024

veroandreo commented Nov 18, 2024

ecodiv commented Dec 3, 2024

ecodiv left a comment

Choose a reason for hiding this comment

cwhite911 commented Dec 23, 2024

veroandreo left a comment

Choose a reason for hiding this comment

veroandreo left a comment

Choose a reason for hiding this comment

veroandreo Jan 31, 2025

Choose a reason for hiding this comment

veroandreo Jan 31, 2025

Choose a reason for hiding this comment

veroandreo Jan 31, 2025

Choose a reason for hiding this comment