r.buildvrt.gdal: Create GDAL VRTs for GDAL linked raster maps #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninsbl
added
new addon
wenzeslaus
requested changes
Sep 22, 2024
Comment on lines
110
to
113
| # Get native GRASS GIS format header | ||
| gdal_path = Path(gs.find_file(map_name)["file"].replace("/cell/", "/cellhd/")) | ||
| if gdal_path.exists(): | ||
| return gdal_path |
There was a problem hiding this comment.
I'm not sure how to handle that, but I did hit this issue in the past. It seems we should have API to make usage of GRASS Driver easier. Perhaps spit a GDAL-compatible path out in r.info output?
There was a problem hiding this comment.
Would you mind opening an issue for this?
wenzeslaus
changed the title
neteler
reviewed
Sep 22, 2024
Co-authored-by: Vaclav Petras <[email protected]> Co-authored-by: Markus Neteler <[email protected]>
|
The requested changes should be addressed. |
wenzeslaus
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A workaround for OSGeo/grass#4345